Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer local chunkserver+debian updates #277

Open
wants to merge 7 commits into
base: 2.5.4
Choose a base branch
from

Conversation

eigood
Copy link
Contributor

@eigood eigood commented May 19, 2015

This adds the enhancement mentioned in #250. It also improves the debian packaging a little bit.

that is running on the same node as a chunkserver will prefer replicated
chunks to be serviced by the local node.
When building the documentation, some additional xml based packages need
to be installed.
Certain packages have no binary programs, so there is no shared libarry
dependencies to calculate.
conffile updates itself.  This brings this package more inline with
debian policy.
@eigood
Copy link
Contributor Author

eigood commented May 19, 2015

The package was not lintian clean. shlibs is for shared-libs, aka compiled packages.

ps: my other persona is doogie@debian.org, but I haven't been active.

@eigood
Copy link
Contributor Author

eigood commented May 19, 2015

So, removing is fine, but the arch also needs to be changed to all, as there is no compiled files in those packages.

@onlyjob
Copy link
Member

onlyjob commented May 19, 2015

Hello, fellow DD ;)
Don't be surprised but we already have a finished LizardFS packaging for Debian here. Besides LizardFS is waiting for approval in NEW for over a month already. I shall be happy to give you a URL with binary packages over email.

@psarna
Copy link
Member

psarna commented May 20, 2015

@eigood , thanks for a valuable contribution!

PREFER_LOCAL_CHUNKSERVER commit is under review in here: http://cr.skytechnology.pl:8081/#/c/1586 , although we need to implement and add some tests to the commit before merging it.
As for debian-related commits, we will handle them slightly later, but we won't forget about them:)

@eigood
Copy link
Contributor Author

eigood commented May 20, 2015

The by-hand testing I did was to configure multiple docker instances, for chunkserver and master. Make certain the data can be read/written. Apply my change, recompile, upgrade, make certain data is still accessible.

I didn't have a way to simulate the load we had been seeing. If this patch is accepted, however, we'd go about deploying it to the backuppc cluster we have(which is actually still moosefs).

@psarna
Copy link
Member

psarna commented May 20, 2015

@onlyjob, you have a point, a decent solution to this problem is refactoring/rewriting topology feature as a whole - and we already have a plan of doing so. I'm not able to tell you when, but this needs to be done anyway.

@eigood
Copy link
Contributor Author

eigood commented May 21, 2015

Hmm. Test cases, eh? I need to make some time to understand the test case system for lizardfs. I saw other things in gerrit that interest me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants