refactor(ai): improve select retry ctx logic #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refines context handling in the orchestrator selection loop for idiomatic Go and enhanced propagation of parent cancellations.
rickstaa
force-pushed
the
improve_selection_retry_context_logic
branch
from
70674d1
to
ca3caef
Compare
This was referenced May 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This commit refines context handling in the orchestrator selection loop for idiomatic Go and enhanced propagation of parent cancellations.
Specific updates (required)
How did you test each of these updates (required)
I ran the O onchain and verified the timeout still successfully triggered a ctx cancel and returned out of the loop.
Does this pull request close any open issues?
Fixes usefull improvements remakrs made by @yondonfu in #3030 (comment).
Checklist:
makeruns successfully./test.shpass