Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#685 - Restructure Node Selector #1535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pgokul
Copy link

@pgokul pgokul commented Mar 21, 2023

  1. Add support for selecting a node for meeting or for draining as a selection argument
  2. Add support for hard limits for cpu and sysload.
  3. Add support for selector chaining. Selectors can now be chained to create more complex selectors out of simple basic ones
  4. Add config changes to allow specifying multiple node selectors to be chained

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1. Add support for selecting a node for meeting or for draining as a selection argument
2. Add support for hard limits for cpu and sysload and generally for any node its applicable to.
3. Add support for selector chaining. Selectors can now be chained to create more complex selectors out of simple basic ones
4. Add config changes to allow specifying multiple node selectors to be chained
@davidzhao
Copy link
Member

Thank you @pgokul for taking this up. I'll review the PR this week. I appreciate your patience.

@pgokul
Copy link
Author

pgokul commented May 22, 2023

Hi @davidzhao , any update on this? Thanks.

@davidzhao
Copy link
Member

Sorry for the delays here, I have not had a chance to review this in detail. I hope to be able to take a deeper look next week. Thank you for your contributions and patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants