This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22650 ]] Fix crash on iOS player #7510
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a crash/freeze when repeatedly setting the same filename in an iOS player.
livecodepanos
force-pushed
the
bugfix-22650
branch
from
df745fc
to
9245649
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a crash/freeze when repeatedly setting the same filename in an iOS player.
The patch ensures that two
AVPlayerItems are checked for equality correctly, so the rest of thesetCurrentItemmethod is not executed.However, when setting repeatedly different filenames, the crash/freeze is still present. It happens completely randomly, it can happen at the second attempt to change the filename, or even at the 20th one. It looks like something in the
setCurrentItemmethod is the culprit.This, setting it to WIP for now.