Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 22994 ]] Fix crash when setting the startTime of a video on iOS #7492

Open
wants to merge 1 commit into
base: develop-9.6
Choose a base branch
from
Open

[[ Bug 22994 ]] Fix crash when setting the startTime of a video on iOS #7492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/notes/bugfix-22994.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Fix crash when setting the startTime of a video on iOS
2 changes: 1 addition & 1 deletion engine/src/mbliphoneplayer.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ static void content_to_url(MCStringRef p_file, NSURL*& r_url)
m_start_time = CMTimeMake(p_time, 1000);

if (m_player != nil)
m_player.currentItem.reversePlaybackEndTime = m_start_time;
SetCurrentTime(ctxt, p_time);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@livecodepanos SetCurrentTime just seeks to that position. the startTime should specify the position that the video begins playback from, including when looping

}

void MCiOSPlayerControl::GetStartTime(MCExecContext& ctxt, integer_t& r_time)
Expand Down