fix: Make select boxes validate if no value provided and default is set

live627 · Mar 16, 2021 · 05605a2 · 05605a2
1 parent 4abc062
commit 05605a2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Class-CustomForm.php b/src/Class-CustomForm.php
@@ -170,7 +170,7 @@ public function setHtml()
 	}
 	public function validate(): bool
 	{
-		$found = isset(array_flip($this->type_vars)[$this->value]);
+		$found = isset(array_flip($this->type_vars)[$this->value]) || !empty($this->default);
 
 		if (!$found && $this->required)
 			$this->err = array('pf_invalid_value', $this->field['name']);

diff --git a/tests/Test.php b/tests/Test.php
@@ -78,7 +78,8 @@ public function selectProvider(): array
 	{
 		return [
 			['gold,silver,bronze,default=silver', '', 'silver'],
-			['gold,silver,bronze,default=', 'silver', 'silver']
+			['gold,silver,bronze,default=', 'silver', 'silver'],
+			['gold,silver,bronze,default=silver', 'titanium', 'silver']
 		];
 	}