Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pre-commit.sh to check for unused strings in strings.en.yaml #4596

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated pre-commit.sh to check for unused strings in strings.en.yaml #4596

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26c9145
updated pre-commit.sh to check for unused strings in strings.en.yaml
shruti2522 Apr 23, 2024
40cf4c6
updated pre-commit.sh
shruti2522 Apr 26, 2024
8200bce
Merge branch 'master' into pre-commit-check
namkyu1999 May 13, 2024
171781c
Merge branch 'master' into pre-commit-check
namkyu1999 May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 17 additions & 8 deletions chaoscenter/web/.husky/pre-commit
View file
Open in desktop
@@ -1,8 +1,9 @@
#!/bin/sh
"$(dirname "$0")/_/husky.sh"

MATCH_PATH='chaoscenter/web/'
echo "\033[0;31;1mYou can't commit directly to main branch\033[0m"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this line correct? this will be printed for each pre-commit hook irrespective to the branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tested properly?
In Litmus there is no main branch, we have a master branch here. Please verify this change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not changed the code for this, it is how the original implementation is in pre-commit.sh. Should I change it to master then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @shruti2522 that went unnoticed by me. Please change it to master.


MATCH_PATH='chaoscenter/web/'
BRANCH=$(git rev-parse --abbrev-ref HEAD)

if [ "$BRANCH" = "main" ]; then
Expand All @@ -16,12 +17,20 @@ if expr "$BRANCH" : 'release\/.*' >/dev/null; then
fi

LITMUS_UI_FILE_CHANGES=$(git diff --name-only --cached | grep "$MATCH_PATH" -c)

echo "\033[0;93mLITMUS_UI_FILE_CHANGES\033[0m ⟶ $LITMUS_UI_FILE_CHANGES"

if [ "$LITMUS_UI_FILE_CHANGES" -gt 0 ];
then
cd ./chaoscenter/web && yarn lint-staged
else
echo "\033[0;93mSkipping husky pre-commit hook in $MATCH_PATH folder\033[0m"
fi
if [ "$LITMUS_UI_FILE_CHANGES" -gt 0 ]; then
cd ./chaoscenter/web && yarn lint-staged
else
echo "\033[0;93mSkipping husky pre-commit hook in $MATCH_PATH folder\033[0m"
fi

# check for unused strings in strings.en.yaml
UNUSED_STRINGS=$(grep -Fvxf <(grep -oP '"\K[^"]+' ./chaoscenter/web/strings/strings.en.yaml) <(grep -rl 'chaoscenter/web/src' ./*))
if [ "$UNUSED_STRINGS" != "" ]; then
echo "\033[0;31;1mERROR: Unused strings found in strings.en.yaml\033[0m"
echo "$UNUSED_STRINGS"
exit 1
fi

exit 0