Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refectoring: refectoring code #4586

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

yj-yoo
Copy link
Contributor

@yj-yoo yj-yoo commented Apr 16, 2024

Proposed changes

  • Remove unnecessary initial value settings
  • Remove unused variables
  • Added missing error handling
  • Remove unnecessary string nil check
  • Remove unnecessary fmt.Sprintf()
  • Add cancel to context.WithTimeout()

Types of changes

refactoring

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

- Remove unnecessary initial value settings
- Remove unused variables
- Added missing error handling
- Remove unnecessary string nil check
- Remove unnecessary fmt.Sprintf()
- Add cancel to context.WithTimeout()

Signed-off-by: Youngjun <yj.yoo@okestro.com>
@@ -14,7 +14,7 @@ func ValidateRole(ctx context.Context, projectID string,
requiredRoles []string, invitation string) error {
jwt := ctx.Value(AuthKey).(string)
var conn *grpc2.ClientConn
client, conn := grpc.GetAuthGRPCSvcClient(conn)
client, conn := grpc.GetAuthGRPCSvcClient()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants