Implemented test case for JwtMiddleware #4418 #4411
Conversation
|
@nikzayn Can you please attach screenshots for the executed testcases and coverage? |
|
@nikzayn please address the comments, so that we can merge this PR |
Sorry, for the delay. I was actually out of town. I came back yesterday. I will update you on the following soon..! |
I will update for sure..!! |
|
Here are the screenshots of test execution and coverage output. 
|
Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
| type MockApplicationService struct{} | ||
|
|
||
| // AddMember implements services.ApplicationService. | ||
| func (m *MockApplicationService) AddMember(projectID string, member *entities.Member) error { |
There was a problem hiding this comment.
@nikzayn you can remove all these generated functions that are unimplemented.
| }) | ||
|
|
||
| // Subtest for Missing Authorization Header | ||
| t.Run("Missing Authorization Header", func(t *testing.T) { |
There was a problem hiding this comment.
I see there's 30% code coverage with this TC, please check if you can add more TCs for more code coverage
| @@ -0,0 +1,142 @@ | |||
|
|
|||
There was a problem hiding this comment.
@nikzayn you can remove both the coverage files, you don't need to commit those generated files.
|
@nikzayn are you still working on this PR? |
Proposed changes
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Dependency
chaoscenter/authentication/api/middleware/jwt_middlware.go#4410)Special notes for your reviewer: