fix: Updated target application drawer (#4078)

Signed-off-by: Hrishav <hrishav.kumar@harness.io>
litmuschaos · Jul 6, 2023 · ec6a4e3 · ec6a4e3
1 parent e3986e4
commit ec6a4e3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 22 deletions.
diff --git a/chaoscenter/web/src/routes/RouteDestinations.tsx b/chaoscenter/web/src/routes/RouteDestinations.tsx
@@ -40,7 +40,8 @@ export function RoutesWithAuthentication(): React.ReactElement {
     if (!token || !isUserAuthenticated()) {
       forceLogout();
     }
-  }, [forceLogout, token]);
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, [token]);
 
   return (
     <Switch>

diff --git a/chaoscenter/web/src/strings/strings.en.yaml b/chaoscenter/web/src/strings/strings.en.yaml
@@ -347,7 +347,7 @@ genericResourceNotFoundError: >-
   has been deleted.
 gitConnection: Repository Connection
 goBack: Go back to previous page
-goChaosHome: Go to Chaos Home
+goChaosHome: Go to Home
 greatJob: Great Job
 group: Group
 healthy: Healthy

diff --git a/...c/views/ExperimentCreationFaultConfiguration/Tabs/TargetApplication/TargetApplication.tsx b/...c/views/ExperimentCreationFaultConfiguration/Tabs/TargetApplication/TargetApplication.tsx
@@ -56,7 +56,8 @@ export default function TargetApplicationTab({
       <Container padding={{ left: 'xxlarge', right: 'xxlarge', top: 'xlarge', bottom: 'xlarge' }}>
         <Text font={{ variation: FontVariation.BODY }}>{getString('provideTargetApplicationDetails')}</Text>
         {engineCR?.spec?.appinfo?.appkind !== undefined && (
-          <Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }}>
+          <Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }} spacing="xsmall">
+            <Text font={{ variation: FontVariation.FORM_LABEL }}>{getString('appKind')}</Text>
             <DropDown
               width={'50%'}
               placeholder={getString('selectAppKind')}
@@ -72,29 +73,13 @@ export default function TargetApplicationTab({
                 setFaultData(faultData => {
                   if (faultData?.faultName) return { ...faultData, engineCR: faultData?.engineCR };
                 });
-                // gvrData.map(data => {
-                //   if (data.resource === selectedItem.label) {
-                //     getKubeObjectLazyQueryFunction({
-                //       variables: {
-                //         kubeObjectRequest: {
-                //           infraID: infrastructureID ?? '',
-                //           requestID: uuid(),
-                //           kubeObjRequest: {
-                //             group: data.group,
-                //             version: data.version,
-                //             resource: `${data.resource}s`
-                //           }
-                //         }
-                //       }
-                //     });
-                //   }
-                // });
               }}
             />
           </Layout.Vertical>
         )}
         {engineCR?.spec?.appinfo?.appns !== undefined && (
-          <Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }}>
+          <Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }} spacing="xsmall">
+            <Text font={{ variation: FontVariation.FORM_LABEL }}>{getString('appNameSpace')}</Text>
             <DropDown
               width={'50%'}
               placeholder={getString('selectAppNamespace')}
@@ -112,7 +97,8 @@ export default function TargetApplicationTab({
           </Layout.Vertical>
         )}
         {engineCR?.spec?.appinfo?.applabel !== undefined && (
-          <Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }}>
+          <Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }} spacing="xsmall">
+            <Text font={{ variation: FontVariation.FORM_LABEL }}>{getString('appLabel')}</Text>
             <DropDown
               width={'50%'}
               placeholder={getString('selectAppLabel')}