Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP Label Selector Experiment Tests #380

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

neelanjan00
Copy link
Member

@neelanjan00 neelanjan00 commented May 18, 2022

Proposed changes

  • Updates GCP Pipeline for adding labels to target instances and disks
  • Adds BDD tests for gcp-vm-instance-stop-by-label and gcp-vm-disk-loss-by-label experiments

How has this been tested:

  • Test environment
    • GKE
    • AWS
    • OpenShift
    • KinD/k3s/k3d cluster
    • Others
  • Tested with production environment ( For ChaosCenter Tests )
  • Have not tested

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • I have added necessary documentation (if appropriate)
  • I have added Screenshots or Terminal snippets in the PR comment to validate the successful execution of changes

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • data-cy=* parameters have been added in codebase ( ChaosCenter Tests )
  • data-cy=* parameters need to be added in codebase ( ChaosCenter Tests )
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. uncaught exceptions from 3rd party library (if any)

Issue

  • Tasks in issue are checked off

Dependency

litmuschaos/litmus-go#523

Notes for Reviewer

Example workflow run: https://github.com/neelanjan00/litmus-e2e/runs/6858990277?check_suite_focus=true

… Makefile

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
Copy link
Contributor

@avaakash avaakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide the link to the test run for this pipeline?

@neelanjan00
Copy link
Member Author

Can you provide the link to the test run for this pipeline?

Currently, the pipeline is failing due to a bug in the experiment code of the gcp-vm-disk-loss-by-label experiment for which this PR has been raised. You can take a look at this pipeline run for your reference, I will update a successful pipeline run after that PR is merged.

Signed-off-by: Neelanjan Manna <neelanjan.manna@harness.io>
@neelanjan00 neelanjan00 removed the DO NOT MERGE do not merge it label Jun 13, 2022
@avaakash avaakash self-requested a review June 21, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants