Improving litmus-docs by some characteristics and experiment creation #250
+1,419
−1,181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshikavashistha
requested review from
divya-mohan0209,
ksatchit and
k8s-dev
as code owners
❌ Deploy Preview for litmus-docs-411023 failed.
|
|
@anshikavashistha is attempting to deploy a commit to the Harness Chaos Team Team on Vercel. A member of the Team first needs to authorize it. |
anshikavashistha
force-pushed
the
Improvement-of-litmus-docs
branch
from
2408ba4
to
eb5d308
Compare
|
@divya-mohan0209 @ksatchit Please review the PR |
neelanjan00
requested changes
Feb 23, 2024
Comment on lines
51
to
61
| ### Experiment Creation | ||
|
|
||
| When creating an experiment, it's imperative to include the Resilience Probe as part of the setup. This step is now mandatory to ensure accurate chaos injection and monitoring during the experiment. Follow these steps to add the probe to the experiment configuration: | ||
|
|
||
| 1. **Identify Chaos Injection Points**: Determine the points within your system where chaos will be injected. | ||
|
|
||
| 2. **Select Resilience Probe**: Choose the appropriate Resilience Probe that aligns with your experimentation goals and the type of chaos you want to inject as discussed above. | ||
|
|
||
| 3. **Integrate Probe into Experiment YAML**: Add the Resilience Probe configuration to your experiment YAML file. Ensure that the probe is properly configured and referenced within the experiment setup. | ||
|
|
||
| 4. **Validate Experiment Configuration**: Before initiating the experiment, validate the experiment configuration to ensure that the Resilience Probe is correctly included and configured. |
There was a problem hiding this comment.
We don't need these changes here, rather in the Schedule a Chaos Experiment page we need to add one more step for adding a probe to a fault.
We can just add a note here that at least one resilience probe needs to be added to each fault now.
There was a problem hiding this comment.
I have added the note for the same you have mentioned to be in create-resilience-probe.md
For further changes in Schedule a Chaos Experiment,Should I do these changes in the same PR or opened a new issue?
There was a problem hiding this comment.
We can take the changes in this PR itself.
anshikavashistha
force-pushed
the
Improvement-of-litmus-docs
branch
from
cf81223
to
0e9fc71
Compare
|
@neelanjan00 I have done the suggested changes .Kindly review the PR |
Please add the remaining changes for modifying the Schedule a Chaos Experiment page, will review once all the changes are in place. |
neelanjan00
requested changes
Feb 26, 2024
anshikavashistha
force-pushed
the
Improvement-of-litmus-docs
branch
from
3455bd0
to
07708a8
Compare
neelanjan00
requested changes
Mar 12, 2024
neelanjan00
requested changes
Mar 12, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* chore: add faq Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> * fix: add latest crds link Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> * Update website/docs/troubleshooting.md Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> --------- Signed-off-by: namkyu1999 <lak9348@konkuk.ac.kr> Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io> Signed-off-by: Your Full Name <your_email@example.com>
Signed-off-by: anshikavashistha <anshikav1534@gmail.com> Signed-off-by: Your Full Name <your_email@example.com>
Co-authored-by: Neelanjan Manna <neelanjanmanna@gmail.com> Signed-off-by: Your Full Name <your_email@example.com>
Signed-off-by: Your Full Name <your_email@example.com>
Signed-off-by: Your Full Name <your_email@example.com>
Signed-off-by: Your Full Name <your_email@example.com>
Co-authored-by: Neelanjan Manna <neelanjanmanna@gmail.com> Signed-off-by: Your Full Name <your_email@example.com>
Co-authored-by: Neelanjan Manna <neelanjanmanna@gmail.com> Signed-off-by: Your Full Name <your_email@example.com>
Co-authored-by: Neelanjan Manna <neelanjanmanna@gmail.com> Signed-off-by: Your Full Name <your_email@example.com>
Updating the troubleshooting.md Co-authored-by: Neelanjan Manna <neelanjanmanna@gmail.com> Signed-off-by: Your Full Name <your_email@example.com>
Co-authored-by: Neelanjan Manna <neelanjanmanna@gmail.com> Signed-off-by: Your Full Name <your_email@example.com>
Adding note Co-authored-by: Neelanjan Manna <neelanjanmanna@gmail.com> Signed-off-by: Your Full Name <your_email@example.com>
anshikavashistha
force-pushed
the
Improvement-of-litmus-docs
branch
from
65a23cb
to
c0c31a5
Compare
|
@neelanjan00 I have done the requested changes which you have mentioned. |
|
Please resolve the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #4378Special notes for your reviewer:
Checklist:
documentationtag