Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an 'ibm' extra package #1337

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tomwhite
Copy link
Contributor

@tomwhite tomwhite commented May 9, 2024

Part of #1324

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@JosepSampe
Copy link
Member

Not sure if you want to tackle this here, but the kubernetes package is also required by IBM Code Engine, so it should be placed inside IBM extra. In consequence, you should also create lithops[kubernetes] and lithops[knative] containing the kubernetes package

@tomwhite
Copy link
Contributor Author

tomwhite commented May 9, 2024

Thanks for the guidance @JosepSampe. How does this look?

@JosepSampe
Copy link
Member

Great! From my side I'm fine with the change, but as I stated in the issue, I wanted to get @gilv's approval, as IBM packages have been always in the default installation

@JosepSampe
Copy link
Member

@gilv Any comment/objection on this? If no, I will proceed to merge it

@JosepSampe
Copy link
Member

@tomwhite can you update the IBM CE and IBM VPC docs and include the installation step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants