Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: relationship loader api #192

Merged
merged 38 commits into from May 21, 2024
Merged

feat: relationship loader api #192

merged 38 commits into from May 21, 2024

Conversation

cofin
Copy link
Member

@cofin cofin commented May 12, 2024

Description

Closes

@cofin cofin requested review from a team as code owners May 12, 2024 03:16
@cofin cofin mentioned this pull request May 13, 2024
Closed
5 tasks
Alc-Alc
Alc-Alc approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@Alc-Alc Alc-Alc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, those aside, this PR is loaded

tests/integration/test_loader_and_execution_options.py Outdated Show resolved Hide resolved
tests/integration/test_loader_and_execution_options.py Outdated Show resolved Hide resolved
tests/integration/test_loader_and_execution_options.py Outdated Show resolved Hide resolved
cofin and others added 3 commits May 15, 2024 11:03
@cofin @Alc-Alc
Update tests/integration/test_loader_and_execution_options.py
cdabd09 
Co-authored-by: Alc-Alc <45509143+Alc-Alc@users.noreply.github.com>
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
@cofin @Alc-Alc
Update tests/integration/test_loader_and_execution_options.py
226397c 
Co-authored-by: Alc-Alc <45509143+Alc-Alc@users.noreply.github.com>
Signed-off-by: Cody Fincher <204685+cofin@users.noreply.github.com>
@cofin
feat: address comments
03fb71d
peterschutt
peterschutt reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@peterschutt peterschutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments on the things I changed in base.py

advanced_alchemy/base.py Show resolved Hide resolved
advanced_alchemy/base.py Show resolved Hide resolved
advanced_alchemy/base.py Show resolved Hide resolved
provinzkraut
provinzkraut requested changes May 16, 2024
View reviewed changes
Copy link
Member

@provinzkraut provinzkraut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet done with the full thing but there's one major issue I see

advanced_alchemy/repository/_async.py Outdated Show resolved Hide resolved
advanced_alchemy/repository/_async.py Outdated Show resolved Hide resolved
@provinzkraut
fix: loader options passing (#195)
1fdef1b 
* Fix loader_options
* Fix execution_options
* Remove unused params
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
87.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/advanced-alchemy-docs-preview/192

@cofin cofin merged commit f665778 into main May 21, 2024
13 checks passed
@cofin cofin deleted the relationship-loader branch May 21, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschutt peterschutt peterschutt left review comments

@provinzkraut provinzkraut provinzkraut approved these changes

@Alc-Alc Alc-Alc Alc-Alc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cofin @peterschutt @provinzkraut @Alc-Alc @gazorby