Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/voice method GET to POST #90

Merged
merged 1 commit into from
Mar 11, 2024
Merged

/voice method GET to POST #90

merged 1 commit into from
Mar 11, 2024

Conversation

aka7774
Copy link

@aka7774 aka7774 commented Mar 8, 2024

To avoid GET method string length limitation.

@litagin02
Copy link
Owner

既にGETメソッド前提でAPIを使用している人も多そうなので、単純な変更にはちょっと慎重になっています。
変更ではなく両方受け付ける(GETを受け取ったら非推奨の警告を出す?)というふうにするのがいいのかなと思っています。

@aka7774
Copy link
Author

aka7774 commented Mar 11, 2024

私が愚直にコピペしてendpointを増やすようなプルリクは送りにくいです(メンテナンスコストが増大するから)
非推奨の警告を出す方法のベストプラクティスも把握できてない。stdout?

これはFYIですが、/docs上で音の再生が出来ない問題の原因を見つけたので共有いたします。
(sbv2固有の問題ではなく、Swaggerのバグのようです)
swagger-api/swagger-ui#8398

@litagin02 litagin02 changed the base branch from master to dev March 11, 2024 04:00
@litagin02 litagin02 merged commit 791b663 into litagin02:dev Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants