fix(isHidden): position fixed always return true

liriliri · Mar 2, 2023 · 0041bd1 · 0041bd1
1 parent 2b304bb
commit 0041bd1
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 3 deletions.
diff --git a/src/isHidden.js b/src/isHidden.js
@@ -57,11 +57,31 @@ exports = function(
         overflow = false
     } = {}
 ) {
+    const computedStyle = getComputedStyle(el);
+
     if (display) {
-        return el.offsetParent === null;
+        const tagName = el.tagName;
+        if (
+            tagName === 'BODY' ||
+            tagName === 'HTML' ||
+            computedStyle.position === 'fixed'
+        ) {
+            if (computedStyle.display === 'none') {
+                return true;
+            } else {
+                let cur = el;
+                while ((cur = cur.parentElement)) {
+                    const computedStyle = getComputedStyle(cur);
+                    if (computedStyle.display === 'none') {
+                        return true;
+                    }
+                }
+            }
+        } else if (el.offsetParent === null) {
+            return true;
+        }
     }
 
-    const computedStyle = getComputedStyle(el);
     if (visibility && computedStyle.visibility === 'hidden') {
         return true;
     }

diff --git a/test/isHidden.js b/test/isHidden.js
@@ -31,7 +31,16 @@ it('display', function() {
     const $display = $dom.find('.display');
     expect(isHidden($display.get(0), options)).to.be.true;
     $display.append('<div class="inner"></div>');
-    expect(isHidden($display.find('.inner').get(0), options)).to.be.true;
+    const $inner = $display.find('.inner');
+    expect(isHidden($inner.get(0), options)).to.be.true;
+
+    // position: fixed
+    $inner.css('position', 'fixed');
+    expect(isHidden($inner.get(0), options)).to.be.true;
+    $display.css('display', 'block');
+    expect(isHidden($inner.get(0), options)).to.be.false;
+    $inner.css('display', 'none');
+    expect(isHidden($inner.get(0), options)).to.be.true;
 });
 
 it('visibility', function() {