Mui v5 #109
Draft
Mui v5 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vharmain
reviewed
Apr 13, 2024
Comment on lines
+422
to
+424
| ;; TODO: By telling OL if the left side panel is open, | ||
| ;; it can correctly take this into account when focusing on coordinates. | ||
| ;; (set! (.-padding view) #js [0 0 0 530]) |
There was a problem hiding this comment.
Good point and please do this as well if there's time left after the MUI upgrade! There are a few different cases for the drawer width. Current logic is in :lipas.ui.map.subs/drawer-width subscription.
vharmain
force-pushed
the
master
branch
2 times, most recently
from
a40eedf
to
8c06de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.