Ignore detected block sizes in cdrom provider #3614
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcus Weiner <marcus.weiner@gmail.com>
|
This makes sense to me. There are open PRs on go-diskfs to fix this specific issue (the panics), but I see no reason not to rely on default sizes here. |
deitch
approved these changes
Apr 1, 2021
mudler
added a commit
to mudler/linuxkit
that referenced
this pull request
Jan 27, 2022
davidcassany
pushed a commit
to rancher-sandbox/linuxkit
that referenced
this pull request
May 9, 2023
A backport of linuxkit#3614 (cherry picked from commit e06a1bd)
davidcassany
pushed a commit
to rancher-sandbox/linuxkit
that referenced
this pull request
May 10, 2023
A backport of linuxkit#3614 (cherry picked from commit e06a1bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Ignored detected blocksizes in go-diskfs.
We were running into an issue where the detection is wrong (diskfs/go-diskfs#104) which causes a panic in
metadata(diskfs/go-diskfs#103)- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)