Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mips64el #3596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mips64el #3596

wants to merge 1 commit into from

Conversation

bltavares
Copy link

Partially related to #3401
One of the arguments presented on the past issue is the lack of images on those architectures.

Debian provides a mips64le image as an official package, and it would be useful for embedded development to be able to run docker containers using qemu to validate programs, not only through cross-compilation.

Hopefully, this would also help to ship this to Docker for Windows - docker/for-win#10223 - I'm not sure what's the connection between those projects tho.

- What I did
I've added mips64le support to binfmt files that I found in the project

- How I did it
I followed the examples of #3518

- How to verify it
I don't know how to compile linuxkit, but I guess that if we can run docker run --platform linux/mips64le mips64le/debian:10 echo hello world we are successfull

- Description for the changelog
Includes mips64le as part of binfmt support

- A picture of a cute animal (not mandatory but encouraged)

@wanghuaiqing2010
Copy link

wanghuaiqing2010 commented Feb 8, 2021

@bltavares
1)Please merge the two commits to one commit.
2)Your commit must be correctly signed off.

You have 2 commits incorrectly signed off. To fix, first ensure you have a local copy of your branch by checking out the pull request locally via command line. Next, head to your local branch and run:

git rebase HEAD~2 --signoff

Now your commits will have your sign off. Next run

git push --force-with-lease origin mips64el

Commit sha: 443f251, Author: Bruno Tavares, Committer: GitHub; The sign-off is missing.
Commit sha: 4ab7019, Author: Bruno Tavares, Committer: GitHub; The sign-off is missing.

Include magic binfmt line for mips64le

Signed-off-by: Bruno Tavares <connect+github@bltavares.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants