docker: set oom score adjust to -500 #3555
Open
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, dockerd sets a "-500" oom-score-adjust for itself by default. We're removing this default, and instead: - for dockerd running as systemd unit, set the oom-score through systemd - when manually running dockerd, require users to explicitly set a score This patch is in preparation of those changes. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@justincormack ptal |
|
Not sure this is the right way to do it, linuxkit can set the oom score directly in the config which seems better |
|
Oh, yes, I'd prefer that as well; this was mostly to keep the old behavior, and I'm not really familiar with LinuxKit; can you point me to an example? Happy to update then |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to moby/moby#41528
Currently, dockerd sets a "-500" oom-score-adjust for itself by default.
We're removing this default, and instead:
This patch is in preparation of those changes.