Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Packages and Theme #897

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Update Packages and Theme #897

wants to merge 27 commits into from

Conversation

cjyabraham
Copy link
Collaborator

@cjyabraham cjyabraham commented Apr 4, 2024 •
edited by thetwopct

Dev site

Includes a new version of SafeSVG that incorporates a fix for #567.

Requires #898

@thetwopct
Copy link
Collaborator

thetwopct commented Apr 18, 2024 •
edited

  • Copied across WordPress 6.5 fixes already established on CNCF
  • Spacers not displaying correct height in editor #836 Fixed spacer outline in editor not working properly
  • Fixed a JS error coming from the cover block since we customised it
  • Upgraded npm packages and deleted unused ones
  • Update the gulp script and optimised the webpack configuration (more modern packages, less dependencies)
  • Upgraded Lando/the environment to node 20, updated circleCI to use node 20
  • Reduced minified CSS size from 259kb to 169kb.
  • Removed some Foundation CSS
  • Preload font on home page
  • Upgrade jQuery to 3.7.1
  • Refactored the src and dist folders and associated build process
  • We now have 0 vulnerabilities in this theme - need to update some of the plugins still.

Screenshot-2024-04-18 --19 22 48

Locally, I think you should run lando rebuild -y to use node 20. Confirm with lando node -v after the rebuild.

@thetwopct thetwopct changed the title Upgrade to WP 6.5 Update Packages and Theme Apr 19, 2024
cjyabraham and others added 24 commits April 20, 2024 16:45
@cjyabraham @thetwopct
Upgrade to WP 6.5
d9ce250 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
fix code sniffs
a486ffb 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
Remove patched Save-SVG plugin from our repo (#567)
29385ac 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
Install safe-svg via composer
4c5e0da 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
Updgrade to WP 6.5.2
159048b 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
#836 Properly outline Spacers in Editor
cf9f174 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
#865 Fixing JS error on Cover when no video present
693197e 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Modernising build process
6734222 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Update build process to use node to match lando
f38072a 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Restore some debug helpers now working
7169af7 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Revert transistion stylesheet
af6a9a3 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Optimise font loading and formats
6b73765 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Moving fonts to top of stack, font-display optional
0c5d237 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Reverting font-face to fallback
91702d8 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Refactor theme and optimise asset loading and build process
8d2b298 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Various fixes
e06d09b 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
CSS tidy
3feeadf 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Update home hero paragraph width
cd05c82 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Update editor build
4d10f2b 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Removing unused foundation, preloading font on home
eeb0b73 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Change event titles to own style, change to H3
5d6a393 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Changing event title to H2 so sequential
3923e37 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Optimise SVGs
92b2ddf 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
More optimisations
44899d1 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Fix sniffs
b77bbc6 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Load blocks CSS seperately
da48d54 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Optmize SVGs, remove empty unused package-lock.json
6f7e955 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Copy link
Collaborator

thetwopct commented Apr 21, 2024 •
edited

Fixed needed

Source of a few issues likely to do with Gutenberg specificity - caused by this line
See WordPress/gutenberg#36834
Possibly also dequeue / filter some stuff to get rid of Gutenberg !important junk.

  1. Buttons have changed

https://pr-897-lfeventsci.pantheonsite.io/about/sponsor/
is smaller than
https://events.linuxfoundation.org/about/sponsor/
and here the button wraps strangely
https://pr-897-lfeventsci.pantheonsite.io/kubecon-cloudnativecon-north-america/
compared to
https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america/

Another
https://pr-897-lfeventsci.pantheonsite.io/kubecon-cloudnativecon-north-america/contact-us/

  1. List indents have changed

From https://pr-897-lfeventsci.pantheonsite.io/kubecon-cloudnativecon-north-america/attend/salt-lake-city/
to
https://events.linuxfoundation.org/kubecon-cloudnativecon-north-america/attend/salt-lake-city/

  1. Tables
    headers have changed
    https://pr-897-lfeventsci.pantheonsite.io/kubecon-cloudnativecon-north-america/attend/code-of-conduct/#if-you-witness-unacceptable-behavior

Bottom margin changed
https://pr-897-lfeventsci.pantheonsite.io/kubecon-cloudnativecon-north-america/co-located-events/cncf-hosted-co-located-events-overview/#submit-a-cncf-project-or-co-located-event-proposal

  1. Photo Gallery no longer in the container
    https://pr-897-lfeventsci.pantheonsite.io/cloudnativesecuritycon-north-america/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thetwopct thetwopct

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cjyabraham @thetwopct