Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open_posix: fix the sigaction testcase cannot running multi times #1067

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

extinguish
Copy link

@extinguish extinguish commented Aug 31, 2023

open_posix: fix the ltp_interfaces_sigaction_23_10 deadloop at second run

Signed-off-by: guohao15 guohao15@xiaomi.com

Signed-off-by: guohao15 <guohao15@xiaomi.com>
@extinguish extinguish changed the title test:ltp fix ltp_interfaces_sigaction_23_10 deadloop at second run open_posix: fix the sigaction testcase cannot running multi times Sep 1, 2023
@richiejp richiejp added the posix POSIX conformance test suite label Nov 24, 2023
@@ -123,6 +123,8 @@ int main(void)

struct sigaction sa;

called = 0;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right, the variable is initialized when it's declared.

@metan-ucw
Copy link
Member

I do not get how the test can run multiple times at all, the main() function is called exactly once so there is no need to reset the value at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
posix POSIX conformance test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants