Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to harmonize output #106

Open
SilasK opened this issue Sep 28, 2022 · 6 comments
Open

How to harmonize output #106

SilasK opened this issue Sep 28, 2022 · 6 comments

Comments

@SilasK
Copy link

SilasK commented Sep 28, 2022

dbcan perform 3 annotations: Diamond, eCAMI, and HMMR. The output of the tree don't necessarily agree. Do you have a preferred way to harmonize them?
Should we trust HMMR more? Is DIAMOND really reliable?

I know in the publication you had different comparisons, but this was before eCAMI was added.

@SilasK
Copy link
Author

SilasK commented Sep 28, 2022

@yinlabniu
Copy link
Collaborator

yinlabniu commented Sep 28, 2022 via email

@SilasK
Copy link
Author

SilasK commented Sep 29, 2022

Thank you for the clarification. Would you still keep diamond prediction for genes that are not annotated with the other two tools? And if yes to down to the default E-value threshold?

Also if Hmmer predicts one annotation and DIamond 2 you wouldn't keep the second from diamond.

@yinlabniu
Copy link
Collaborator

yinlabniu commented Sep 29, 2022 via email

@SilasK
Copy link
Author

SilasK commented Sep 30, 2022

Ok, you keep annotations that are predicted by two tools. I saw this gave the best performance shown in the publication.
This means you also drop annotations that come from only HMMER?

@yinlabniu
Copy link
Collaborator

that's right. if only hmmer generates output and the other two are not, we drop it. But users can decide to keep it since you have the raw results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants