Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: first pass at unified model transformations #1423

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cmungall
Copy link
Member

@cmungall cmungall commented May 5, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (f939bfc) 80.03% compared to head (c0e4fbe) 79.79%.

❗ Current head c0e4fbe differs from pull request most recent head 0673211. Consider uploading reports for the commit 0673211 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1423      +/-   ##
==========================================
- Coverage   80.03%   79.79%   -0.25%     
==========================================
  Files          98       79      -19     
  Lines       10860     9190    -1670     
  Branches     2744     2233     -511     
==========================================
- Hits         8692     7333    -1359     
+ Misses       1661     1419     -242     
+ Partials      507      438      -69     
Files Coverage Δ
linkml/transformers/relmodel_transformer.py 94.90% <100.00%> (+0.12%) ⬆️
linkml/transformers/schema_renamer.py 70.10% <100.00%> (+0.31%) ⬆️
linkml/transformers/model_transformer.py 64.70% <64.70%> (-35.30%) ⬇️
linkml/transformers/oomodel_transformer.py 0.00% <0.00%> (ø)

... and 84 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sierra-moxon sierra-moxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsolicited review; looks good! :). -- just walking through PRs looking to update/close/review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants