Don't require auth for fetching public ical #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flooey, make sure your code change is passing flake8 validation |
|
This probably closes #374 |
The public ical endpoint is designed to be fetched by calendar applications with no authentication, so exclude it from auth enforcement.
flooey
force-pushed
the
flooey/public-ical
branch
from
ea409a8
to
6d9094d
Compare
|
Hey all, just checking in on this. |
|
Is there a reason this never got merged in @diegocepedaw ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public ical endpoint is designed to be fetched by calendar applications with no authentication, so exclude it from auth enforcement.