Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parrallel Producer per partition #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suyashtava
Copy link

@suyashtava suyashtava commented Mar 22, 2023

Issue. #395

This PR aims to provide parallel Producer per partition, so that even if one partition is slow(hosted on slow Brtoker) other producers can easily produce data on other partitions.

@suyashtava
Copy link
Author

Previous Discussion: #375

@mhratson
Copy link
Collaborator

mhratson commented Mar 22, 2023

@suyashtava thanks for the PR, have your observed the memory consumption increase with this approach?
Do you have some data to share?

@suyashtava
Copy link
Author

@suyashtava thanks for the PR, have you observed the memory consumption increase with this approach? Do you have some data to share?

@mhratson There is a small increase in memory. I don't have any comparison data ready at the moment since we changed this months ago in production.

GIve me a day I will reproduce the comparison data on the Weekend.

@suyashtava
Copy link
Author

@mhratson
KMF is running on a Kafka Cluster with total of 12 Brokers, and each Broker is hosting 3 partitions of KMF.

With the existing opensource KMF: It is taking avg 73 MB of Memory, wherease with Parallel Producer(PR): It is taking avg 85 MB of memory.

CPU Usage almost remains untouched.

FYI: We are using java.lang.Memory.HeapMemoryUsage.usedBytes for memory calculation.

@mhratson
Copy link
Collaborator

Have you considered using using async send as alternative? That'd require changing metrics collection a bit rather than than constructing per-partition producer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants