Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable qjournal JN cluster to be set as dfs.namenode.shared.edits.dir to load test JNs #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aswinmprabhu
Copy link

Summary

Dynamometer spins up a simulated NN and makes it write edit logs to a local directory instead of a remote qjournal JN cluster because the primary objective of dynamometer was to load test NNs. But this prevents its usage in load testing JNs as well as an NNs performance w.r.t JN edit log sync.

This PR enables JN load testing using dynamometer by setting the property dfs.namenode.shared.edits.dir if the namenode_edits_dir config starts with qjournal://. If this condition is true, the same JN cluster is used for dfs.namenode.shared.edits.dir as well as dfs.namenode.edits.dir. If the condition is false, dfs.namenode.shared.edits.dir is left empty and dfs.namenode.edits.dir is set to the regular local directory with the prefix file://.

All changes are limited to start-component.sh file which is used as a java resource by Client.java, the dynamometer client used to spin up infra.

Testing Done

Ran the following bash:

#!/bin/bash

NN_EDITS_DIR="/grid/tmpfs/name-data"
baseDir="`pwd`/dyno-node"

qjournalprefix="qjournal://"
if [[ "$NN_EDITS_DIR" == $qjournalprefix* ]]; then
  editsDir="$NN_EDITS_DIR"
  sharedEditsDir="$NN_EDITS_DIR"
  editsDirPathPrefix=""
else
  editsDir=${NN_EDITS_DIR:-${baseDir}/name-data}
  sharedEditsDir=""
  editsDirPathPrefix="file://"
fi

read -r -d '' namenodeConfigs <<EOF
  -D dfs.namenode.edits.dir=${editsDirPathPrefix}${editsDir}
  -D dfs.namenode.shared.edits.dir=${sharedEditsDir}
EOF

echo "$namenodeConfigs"

And got the output:

./dynamo.sh
-D dfs.namenode.edits.dir=file:///grid/tmpfs/name-data
  -D dfs.namenode.shared.edits.dir=

While this bash code:

#!/bin/bash

NN_EDITS_DIR="qjournal://test1.g.linkedin.com:8485;test2.g.linkedin.com:8485;test3.g.linkedin.com:8485/test"
baseDir="`pwd`/dyno-node"

qjournalprefix="qjournal://"
if [[ "$NN_EDITS_DIR" == $qjournalprefix* ]]; then
  editsDir="$NN_EDITS_DIR"
  sharedEditsDir="$NN_EDITS_DIR"
  editsDirPathPrefix=""
else
  editsDir=${NN_EDITS_DIR:-${baseDir}/name-data}
  sharedEditsDir=""
  editsDirPathPrefix="file://"
fi

read -r -d '' namenodeConfigs <<EOF
  -D dfs.namenode.edits.dir=${editsDirPathPrefix}${editsDir}
  -D dfs.namenode.shared.edits.dir=${sharedEditsDir}
EOF

echo "$namenodeConfigs"

Gives the output:

./dynamo.sh
-D dfs.namenode.edits.dir=qjournal://test1.g.linkedin.com:8485;test2.g.linkedin.com:8485;test3.g.linkedin.com:8485/test
  -D dfs.namenode.shared.edits.dir=qjournal://test1.g.linkedin.com:8485;test2.g.linkedin.com:8485;test3.g.linkedin.com:8485/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant