Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log error when specify multiple source paths #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pingsutw
Copy link

No description provided.

@xkrogen
Copy link
Collaborator

xkrogen commented Jul 31, 2019

Hi @pingsutw , I actually don't agree that this is correct. Here is the original code:

    Preconditions.checkArgument(resource.getType() == LocalResourceType.ARCHIVE || srcPaths.length == 1,
        "Can only specify multiple source paths if using an ARCHIVE type");

The preconditions say "the resource is an archive OR there is only one source path", i.e., if the resource is an archive then more than one source path is okay. The message is saying that you can only specify multiple source paths if you use archive, which is consistent with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants