Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kafka version to 3.4 #1973

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

egyedt
Copy link
Contributor

@egyedt egyedt commented Mar 6, 2023

This PR resolves #1960.

@egyedt
Copy link
Contributor Author

egyedt commented Mar 6, 2023

@efeg, @CCisGG, @viktorsomogyi
Could you please review this small upgrade?

@CCisGG
Copy link
Contributor

CCisGG commented Mar 6, 2023

Hi @egyedt , thank you for taking care of this!

The reason we keep kafka-version at 3.1* is LinkedIn is still using kafka 3.0 ~ 3.1. We anticipate we'll stay on that version for at least another few months. Please feel free to update the kafka dependency version on your fork of CC, but we'll keep the version as what it is for now in open source CC.

@erikgb
Copy link

erikgb commented Jan 15, 2024

@CCisGG Can we upgrade the Kafka client used by cruise-control now? Or do we need to fork the project? I would expect the clients to be backward compatible. Forward compatible can be a bit more tricky. We want to connect to our clusters using PEM certificates avoiding the pesky keystores (with passwords). That requires a newer client version.

@CCisGG
Copy link
Contributor

CCisGG commented Jan 15, 2024

@CCisGG Can we upgrade the Kafka client used by cruise-control now? Or do we need to fork the project? I would expect the clients to be backward compatible. Forward compatible can be a bit more tricky. We want to connect to our clusters using PEM certificates avoiding the pesky keystores (with passwords). That requires a newer client version.

Hi @erikgb , thanks for bringing this up. Could you please elaborate a bit more on the "We want to connect to our clusters using PEM certificates avoiding the pesky keystores (with passwords). That requires a newer client version."? Do you mean that using current CC code cannot connect your CC instance to your kafka cluster?

@erikgb
Copy link

erikgb commented Jan 15, 2024

@CCisGG We run CC on Kubernetes, and have automation to issue certificates used to authenticate to our external Kafka clusters. This automation is migrating away from legacy keystores/truststores (both JKS and PKCS#12) to pure PEM format with unencrypted private keys. The current Kafka client used in CC does not allow for this, as it doesn't include https://issues.apache.org/jira/browse/KAFKA-12703. To use unencrypted private keys with PEM, the Kafka client version must be at least 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Kafka version 3.4
3 participants