Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feature: shuffle questions order #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oVerde
Copy link

@oVerde oVerde commented Jul 15, 2022

What?

A new button on the modal so the questions order can be shuffled

Why?

I felt my answers were biased by questions' order, after answering and resetting many times.

How?

A new file shuffle.ts was add to ./src/components/common.
A new svg button add to InformationPanel.
And everything else tied together.

Testing?

Basic testing as the resetHandler already had

Screenshots (optional)

image

Anything Else?

Hope you guys like it as much as I did 😂

@oVerde
Copy link
Author

oVerde commented Jul 16, 2022

Hey @luan0ap, what do you think about this?

Typo on JSDOC
@Ebazhanov Ebazhanov requested a review from wkm97 July 20, 2022 17:31
@wkm97
Copy link
Collaborator

wkm97 commented Jul 22, 2022

Hi @oVerde , thanks for your interest 😁. Is there any blocker when setup the dev environment, like hitting to requirement of GA_MEASUREMENT_ID ? (added new commit to prevent this from happening during dev)

I tried to play with your changes and here are the few things the user (which is me in this case) will be expecting:

  • when hit the shuffle button, the question will rearrange automatically behind, where in the video it only rearrange when the information panel is closed.
  • the numbering in the information panel no longer in sync with the questions.
MD2Practice.-.22.July.2022.mp4

There could also be another alternative such as loading a smaller subset of questions in another page other than linked-practices.tsx to solve the biased by questions' order issue.

@wkm97 wkm97 added the enhancement New feature or request label Jul 22, 2022
@oVerde
Copy link
Author

oVerde commented Jul 22, 2022

Nice catch! Will fix that.
The dev environment went very smooth, thanks, no blockers.

@wkm97 wkm97 added the stale Old PR without anyone working label Oct 8, 2022
@janjitsu
Copy link

bump?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Old PR without anyone working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants