fix: exports attribute on package.json, expo compat #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React Native's Metro bundler expects all imports to be declared in the `exports` attribute when there is one defined. Lingui imports it (to get the version I guess?) and Metro refuses it as it was not defined as a valid export. See eemeli/make-plural#15 for a similar issue on the `make-plural` package The `main` field for `@babel/macro` was also incorrect as there is no `index.ts` in this project.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/lingui-js/js-lingui/DWUmL7hxN5juBUKtQZriLtSdiJcZ |
Codecov Report
@@ Coverage Diff @@
## main #997 +/- ##
=======================================
Coverage 83.24% 83.24%
=======================================
Files 53 53
Lines 1611 1611
Branches 432 432
=======================================
Hits 1341 1341
Misses 157 157
Partials 113 113 Continue to review full report at Codecov.
|
|
Ah super Renaud! thanks for the contribution :) |
semoal
changed the title
|
Released 3.7.1 with this fix =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native's Metro bundler expects all imports to be declared in the
exportsattribute when there is one defined.Lingui imports it (to get the version I guess?) and Metro refuses it as it was not defined as a valid export.
See eemeli/make-plural#15 for a similar issue on the
make-pluralpackageThe
mainfield for@babel/macrowas also incorrect as there is noindex.tsin this project.These 2 changes allowed me to successfully use Lingui on a React Native project.