Event column #646
Event column #646
Conversation
added event column builder added event settings dialogue added event cell renderer
added tooltips with popper added scss
split up event settings into two dialogs
changed time units
✅ Deploy Preview for lineupjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Added custom tooltip callback
There was a problem hiding this comment.
so far just looked at the code without testing it out.
overall looks good and will provide a nice new event type
some general comments
- please add an example with two event columns
- avoid that the model is rendering something, the model is pure data not updating of html
- please generalize the tooltip similar to dialog management, having a magic unique id defined in one and used in the other doesn't scale
- please update to the latest develop branch + make sure that
yarn fixruns without problems.
sgratzl
added
type: feature
moved event xScale from renderer to column
src/renderer/EventCellRenderer.ts
Outdated
| const svg = div.select('svg') as Selection<SVGSVGElement, unknown, null, undefined>; | ||
| svg.selectAll('*').remove(); | ||
|
|
||
| if (n.classList.contains('lu-side-panel-summary')) { |
There was a problem hiding this comment.
take a look at the StringCellRenderer, it uses the interactive flag to separate the side panel from the regular summary
added flag for axis adaption to data or global min/max switched to regular d3 updates fixed popper page slowing by using virtual element instead of creating new instances
added cloning to event column toolbar
|
@sgratzl: @jzethofer has addressed all points from your feedback. Could you please take another look? For me it looks good. |
| } | ||
|
|
||
| onDataUpdate(_rows: ISequence<IDataRow>): void { | ||
| super.onDataUpdate(_rows); |
There was a problem hiding this comment.
I don't understand.
let's say you have 3 events: A, B, C
and 3 rows; [{A: 1, B: 2, C: 3}, {A: 2, B: 3, C: 4}, {A: 3, B: 4, C: 5}]
the user can select which combination of A, B, C to show and you need the min/max of the current selection.
what you can precompute is:
A: min/max of all As: 1,3
B: min/max of all Bs: 2,4
C: min/max of all Cs: 3,5
then you can compute on the fly based on the selection the current selection min max,
e.g
selection = A,B -> min(A.min, B.min), max(A.max, B.max) =1,4
There was a problem hiding this comment.
why do you need to compute all possible combinations?
There was a problem hiding this comment.
The user can also dynamically select a reference event during the analysis.
I add this data row {A:4, B:-2, C:5} to the example and select A as a reference event
Then the value A is subtracted from in each row: [{A: 0, B: 1, C: 2}, {A: 0, B: 1, C: 2}, {A: 0, B: 1, C: 2}, {A:0, B:-6, C:1}]
Also the boxplot values dynamically linked to one column.
for example they are [{min:-2, max 5}, {min:3, max 5}, {min:0, max 8}, {min:0, max 1}]]
then setting the boxplot reference to A would lead to
[{A: 0, B: 1, C: 2, min:-2, max 5}, {A: 0, B: 1, C: 2, min:3, max 5}, {A: 0, B: 1, C: 2, min:0, max 8}, {A:0, B:-6, C:1, min:0, max 1}]
and a min/max of -6/8
setting the boxplot reference to B leads to min/max of -6/9
setting the boxplot reference to C leads to min/max of 0/10
If a column is deselected or the reference event changes min/max can change again.
The min/max therefore depends on the selected columns, reference event, boxplot reference event and the visible data rows. Or am I missing something here?
What I could do is making the min/max calculation independant of the visible data rows and only cache a global min/max for each combination
for me the main point is that the renderer is changing the data of the model, which is a first. |
prerequisites:
Summary
2023-12-20.09-25-48.mp4