Fix: Correct API endpoint mismatch in CredentialController #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fixing API Endpoint Mismatch Issue in CredentialController
Overview or reasons
I have identified an issue in the CredentialController on the server.
Currently, the endpoint for receiving requests is set as /fido2/credentials/{id}, but I noticed that when constructing the API address on the rpserver, it is being called as /fido2/credentials{id}.
As a result, the credentials API cannot be successfully invoked.
Tasks
When calling the credentials API, you need to configure the address of that API in rpserver, pathSegment function when calling the credentials API.
Result
Now able to call the server's credential/{id} api from rpserver as normal.