[Issue-4917] Add blockingTaskExecutor in Thrift services #5619

ChangguHan · 2024-04-18T05:50:45Z

Motivation:

Add blockingTaskExecutor in Thrift services #4917

Modifications:

Add useBlockingTaskExecutor into THttpServiceBuilder.java
Apply useBlockingTaskExecutor into THttpService.java

Result:

Closes Allow useBlockingTaskExecutor in Thrift services #4917. (If this resolves the issue.)
User can use useBlockingTaskExecutor from THttpServiceBuilder.java

CLAassistant · 2024-04-18T05:50:51Z

All committers have signed the CLA.

github-actions · 2024-04-18T06:05:56Z

🔍 Build Scan® (commit: `c072de7`)

Job name	Status	Build Scan®
build-windows-latest-jdk-21	❌ (failure)	https://ge.armeria.dev/s/7jblg5i4z3rzo
build-self-hosted-unsafe-jdk-8	✅	https://ge.armeria.dev/s/hhujegywtqy7s
build-self-hosted-unsafe-jdk-21-snapshot-blockhound	❌ (failure)	https://ge.armeria.dev/s/rthjtmezcs4s2
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/menaz463twoyk
build-self-hosted-unsafe-jdk-17-min-java-11	❌ (failure)	https://ge.armeria.dev/s/jdqxynhxz5k2s
build-self-hosted-unsafe-jdk-17-leak	✅	https://ge.armeria.dev/s/2zzwgjpqtz7u4
build-self-hosted-unsafe-jdk-11	❌ (failure)	https://ge.armeria.dev/s/46gfbcxnz46yk
build-macos-12-jdk-21	❌ (failure)	https://ge.armeria.dev/s/idaoqfk4t4t4m

injae-kim · 2024-04-19T01:20:35Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/THttpService.java

+        if (useBlockingTaskExecutor) {
+            ctx.blockingTaskExecutor().execute(
+                    () -> invoke(ctx, serializationFormat, seqId, f, decodedReq, httpRes)
+            );


we think invoke() is only thing that we should wrap with ctx.blockingTaskExecutor().

If not, please share to us~! 🙇

ikhoon · 2024-04-22T10:52:58Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/THttpService.java

@@ -287,6 +287,7 @@ public static Function<? super RpcService, THttpService> newDecorator(

    private int maxRequestStringLength;
    private int maxRequestContainerLength;
+    private boolean useBlockingTaskExecutor;


Suggested change

private boolean useBlockingTaskExecutor;

private final boolean useBlockingTaskExecutor;

Fixed it. Thank you

ikhoon · 2024-04-22T11:10:47Z

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

+        @Override
+        public void get(TestServiceRequest request,
+                        AsyncMethodCallback resultHandler) throws TException {
+            resultHandler.onComplete(new TestServiceResponse(request.getMessage()));


Could we check whether the current thread is the blocking task executor?

Should we also check TestService.Iface?

Could we check whether the current thread is the blocking task executor?

I checked it here

armeria/thrift/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

Line 81 in 6649eee

assertThat(blocking).isFalse();

Should we also check TestService.Iface?

Fixed it. Because of Iface, only verified the current thread is blocking executor without adding useBlockingTaskExecutor

thrift/thrift0.13/src/test/thrift/Test.thrift

minwoox

Looks great to me. 👍
Left minor suggestions. 😉

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/THttpService.java

minwoox

Looks great to me, @ChangguHan 👍 👍 👍
Thanks!

minwoox · 2024-04-23T11:55:48Z

Oops, I realized that we also need to fix ThriftCallService not to use blocking task executor twice:

armeria/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

Line 186 in 10424c7

ctx.blockingTaskExecutor().execute(() -> {

private static void invoke(
        ServiceRequestContext ctx,
        Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

    try {
        final TBase<?, ?> tArgs = func.newArgs(args);
        if (func.isAsync()) {
            invokeAsynchronously(impl, func, tArgs, reply);
        } else if (ctx.eventLoop().inEventLoop()) {
            invokeSynchronously(ctx, impl, func, tArgs, reply);
        } else {
            invokeSynchronously0(ctx, impl, func, tArgs, reply);
        }
    } catch (Throwable t) {
        reply.completeExceptionally(t);
    }
}

private static void invokeSynchronously(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ctx.blockingTaskExecutor().execute(() -> invokeSynchronously0(ctx, impl, func, args, reply));
}

private static void invokeSynchronously0(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ...
}

trustin

Whether to delegate the call to the blocking task executor should be decided by ThriftCallService, not THttpService.

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

ChangguHan · 2024-04-24T12:57:51Z

@trustin
I fix to decide whether to check useBlockingTaskExecutor in ThriftCallService instead of THttpService.
Would you check this?

armeria/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

Lines 125 to 139 in 0963905

    
           if (func.isAsync()) { 
        
               if (useBlockingTaskExecutor) { 
        
                   ctx.blockingTaskExecutor().execute(() -> { 
        
                       try { 
        
                           invokeAsynchronously(impl, func, tArgs, reply); 
        
                       } catch (Throwable t) { 
        
                           reply.completeExceptionally(t); 
        
                       } 
        
                   }); 
        
               } else { 
        
                   invokeAsynchronously(impl, func, tArgs, reply); 
        
               } 
        
           } else { 
        
               invokeSynchronously(ctx, impl, func, tArgs, reply); 
        
           }

ChangguHan · 2024-04-24T12:58:48Z

Oops, I realized that we also need to fix ThriftCallService not to use blocking task executor twice:

armeria/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

Line 186 in 10424c7

ctx.blockingTaskExecutor().execute(() -> {

private static void invoke(
        ServiceRequestContext ctx,
        Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

    try {
        final TBase<?, ?> tArgs = func.newArgs(args);
        if (func.isAsync()) {
            invokeAsynchronously(impl, func, tArgs, reply);
        } else if (ctx.eventLoop().inEventLoop()) {
            invokeSynchronously(ctx, impl, func, tArgs, reply);
        } else {
            invokeSynchronously0(ctx, impl, func, tArgs, reply);
        }
    } catch (Throwable t) {
        reply.completeExceptionally(t);
    }
}

private static void invokeSynchronously(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ctx.blockingTaskExecutor().execute(() -> invokeSynchronously0(ctx, impl, func, args, reply));
}

private static void invokeSynchronously0(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ...
}

@minwoox Thank you for your review.
I fix to check in ThriftCallService!

trustin · 2024-04-30T08:36:26Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

-     * Creates a new {@link ThriftCallService} with the specified service implementation.
-     *
-     * @param implementation an implementation of {@code *.Iface} or {@code *.AsyncIface} service interface
-     *                       generated by the Apache Thrift compiler
+     * Creates a new instance of {@link ThriftCallServiceBuilder} which can build
+     * an instance of {@link ThriftCallService} fluently.
     */
-    public static ThriftCallService of(Object implementation) {
-        requireNonNull(implementation, "implementation");
-        return new ThriftCallService(ImmutableMap.of("", ImmutableList.of(implementation)));
-    }


Shall we keep this method because otherwise we would break backward compatibility? We could reimplement this method like this:

return builder().implementation(implementation).builder();

I applied it. thank you!

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

trustin · 2024-04-30T08:37:35Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+    /**
+     * Adds an implementation for {@link ThriftServiceEntry}.
+     */
+    public ThriftCallServiceBuilder implementation(Object implementation) {


Should we rename this to addService() so it is close to GrpcServiceBuilder?

I change the name of this method. Thank you!

trustin · 2024-04-30T08:40:39Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+ * @see ThriftCallService
+ */
+public final class ThriftCallServiceBuilder {
+    private Map<String, ? extends Iterable<?>> implementations;


What do you think about making this additive, like:

private final ImmutableMap.Builder<String, ...> implementations = ImmutableMap.builder(); ... public ThriftCallService build() { ... final Map<...> implementations = this.implementations.build(); ... } // User code: ThriftCallService .builder() .addService(defaultServceImpl) .addService("foo", fooServiceImpl) .addService("bar", barServiceImpl) .addService("foobar", fooServiceImpl, barServiceImpl) .addServices(ImmutableMap.of("qux", quxServiceImpl, "quz", quzServiceImpl)) .build(); // implementations will contain "", "foo", "bar", "foobar", "qux", "quz".

It looks good.
I applied it. Thank you for your comment.

ChangguHan · 2024-05-07T06:41:25Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+ * @see ThriftCallService
+ */
+public final class ThriftCallServiceBuilder {
+    private final ImmutableMap.Builder<String, Iterable<?>> implementations = ImmutableMap.builder();


Please note that I changed the type of value here.
? extends Iterable<?> -> Iterable<?>

trustin · 2024-05-07T13:28:38Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+    /**
+     * Adds multiple implementations for {@link ThriftServiceEntry}.
+     */
+    public ThriftCallServiceBuilder implementations(Map<String, ? extends Iterable<?>> implementations) {


Maybe we can rename this to addServices as well?

trustin · 2024-05-07T13:31:56Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+     */
+    public ThriftCallServiceBuilder addService(String key, Object implementation) {
+        requireNonNull(implementation, "implementation");
+        this.implementations.put(key, ImmutableList.of(implementation));


This will overwrite the existing map entry under the specified key, making the following code work incorrectly:

builder.addService("foobar", fooService); builder.addService("foobar", barService);

There are two options to fix this here:

Use ImmutableMultiMap.Builder from Guava

Check if there's already a mapping and then merge if so.

Also, it'd be nice if a user is allowed to specify multiple implementations in a single call:

builder.addService("foobar", fooService, barService); // and builder.addService("foobar", ImmutableList.of(fooService, barService));

We could replace addService() with this new method, then.

@trustin
Is it okay to use like this? I also added test here.

armeria/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

Lines 34 to 48 in 649bf67

* * ThriftCallService service = ThriftCallService

* .builder()

* .addService(defaultServiceImpl) // Adds an service

* .addService("foo", fooServiceImpl) // Adds an service with a key

* .addService("foobar", fooServiceImpl) // Adds multiple services to the same key

* .addService("foobar", barServiceImpl)

* .addService("foobarOnce", fooServiceImpl, barServiceImpl) // Adds multiple services at once

* // Adds multiple services by list

* .addService("foobarList", ImmutableList.of(fooServiceImpl, barServiceImpl))

* // Adds multiple services by map

* .addServices(ImmutableMap.of("fooMap", fooServiceImpl, "barMap", barServiceImpl))

* // Adds multiple services by multimap

* .addServices(ImmutableMultimap.of("foobarMultiMap", fooServiceImpl,

* "foobarMultiMap", barServiceImpl))

* .build();

jrhee17

Looks almost done once @trustin 's comments are addressed 👍

jrhee17 · 2024-05-08T00:01:16Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+ * @see ThriftCallService
+ */
+public final class ThriftCallServiceBuilder {
+    private final ImmutableMap.Builder<String, Iterable<?>> implementations = ImmutableMap.builder();


What do you think of consistently naming implementations -> services? Ditto for the method parameters and validations.

Done, Thank you!

jrhee17 · 2024-05-08T00:02:52Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+     */
+    public ThriftCallServiceBuilder addService(String key, Object implementation) {
+        requireNonNull(implementation, "implementation");
+        this.implementations.put(key, ImmutableList.of(implementation));


Suggested change

this.implementations.put(key, ImmutableList.of(implementation));

implementations.put(key, ImmutableList.of(implementation));

jrhee17 · 2024-05-08T00:26:00Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

            ServiceRequestContext ctx,
            Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

        try {
            final TBase<?, ?> tArgs = func.newArgs(args);
            if (func.isAsync()) {
-                invokeAsynchronously(impl, func, tArgs, reply);
+                if (useBlockingTaskExecutor) {
+                    ctx.blockingTaskExecutor().execute(() -> {


Note: I understood that unlike gRPC interceptors, thrift rpcDecorators won't be invoked from the blockingTaskExecutor.

That is correct.
I left this comment to call the Thrift RPC decorators from the blockingTaskExecutor but @trustin suggested using the event loop for executing RPC decorators.

jrhee17 · 2024-05-08T00:34:24Z

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

+            new ScheduledThreadPoolExecutor(1, ThreadFactories.newThreadFactory("blocking-test", true)) {
+                @Override
+                protected void beforeExecute(Thread t, Runnable r) {
+                    blocking.set(true);


This will make blocking=true for any blocking task execution - even if there is a different call path which uses blocking task executors (of which there are many)

Is it possible to just check blocking.set(Thread.currentThread().getName().startsWith("blocking-test")); inside the service call methods instead and remove this logic?

I haven't thought about it.
I appreciate your idea. Thank you.

minwoox

Looks good! Left minor comments. 👍

minwoox · 2024-05-20T14:26:58Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

-    public static ThriftCallService of(Map<String, ? extends Iterable<?>> implementations) {
-        requireNonNull(implementations, "implementations");
-        return new ThriftCallService(implementations);
+    public static ThriftCallServiceBuilder builder() {


nit:

Suggested change

public static ThriftCallServiceBuilder builder() {

@UnstableApi

public static ThriftCallServiceBuilder builder() {

minwoox · 2024-05-20T14:30:04Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+ *  * <pre>{@code
+ *  * ThriftCallService service = ThriftCallService


Suggested change

* * <pre>{@code

* * ThriftCallService service = ThriftCallService

* <pre>{@code

* ThriftCallService service = ThriftCallService

minwoox · 2024-05-20T14:30:15Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+ *                 .addServices(ImmutableMap.of("fooIterableMap",
+ *                                              ImmutableList.of(fooServiceImpl, barServiceImpl)))
+ *                 .build();
+ *  * }</pre>


Suggested change

* * }</pre>

* }</pre>

minwoox · 2024-05-20T14:30:28Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+ *
+ * @see ThriftCallService
+ */
+public final class ThriftCallServiceBuilder {


Suggested change

public final class ThriftCallServiceBuilder {

@UnstableApi

public final class ThriftCallServiceBuilder {

minwoox · 2024-05-20T14:33:28Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+    }
+
+    /**
+     * Adds an service for {@link ThriftServiceEntry}.


Suggested change

* Adds an service for {@link ThriftServiceEntry}.

* Adds a service for {@link ThriftServiceEntry}.

minwoox · 2024-05-20T14:41:36Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+     * Adds an service with a key for {@link ThriftServiceEntry}.
+     */
+    public ThriftCallServiceBuilder addService(String key, Object... service) {
+        requireNonNull(service, "service");


Suggested change

requireNonNull(service, "service");

requireNonNull(key, "key");

requireNonNull(service, "service");

minwoox · 2024-05-20T14:42:38Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+     * Adds services with key by iterable for {@link ThriftServiceEntry}.
+     */
+    public ThriftCallServiceBuilder addService(String key, Iterable<?> service) {
+        if (!service.iterator().hasNext()) {


Suggested change

if (!service.iterator().hasNext()) {

requireNonNull(key, "key");

requireNonNull(service, "service");

if (!service.iterator().hasNext()) {

minwoox · 2024-05-20T14:43:17Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+     */
+    public ThriftCallService build() {
+        return new ThriftCallService(
+                Multimaps.asMap(servicesBuilder.build()).entrySet().stream().collect(


Think we can just call asMap

Suggested change

Multimaps.asMap(servicesBuilder.build()).entrySet().stream().collect(

servicesBuilder.build().asMap().entrySet().stream().collect(

minwoox · 2024-05-20T14:46:41Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

            ServiceRequestContext ctx,
            Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

        try {
            final TBase<?, ?> tArgs = func.newArgs(args);
            if (func.isAsync()) {
-                invokeAsynchronously(impl, func, tArgs, reply);
+                if (useBlockingTaskExecutor) {
+                    ctx.blockingTaskExecutor().execute(() -> {


That is correct.
I left this comment to call the Thrift RPC decorators from the blockingTaskExecutor but @trustin suggested using the event loop for executing RPC decorators.

[Issue-4917] Add blockingTaskExecutor in Thrift services

02c82e0

github-actions bot requested review from ikhoon, jrhee17, minwoox and trustin April 18, 2024 05:50

[Issue-4917] Fix test

3dda165

injae-kim reviewed Apr 19, 2024

View reviewed changes

ikhoon added new feature sprint Issues for OSS Sprint participants labels Apr 22, 2024

ikhoon reviewed Apr 22, 2024

View reviewed changes

[Issue-4917] Add test for Iface

6649eee

minwoox reviewed Apr 23, 2024

View reviewed changes

ChangguHan added 2 commits April 23, 2024 12:00

[Issue-4917] Refactor THttpService.invoke

286f804

[Issue-4917] Fix style

16e9e59

minwoox approved these changes Apr 23, 2024

View reviewed changes

trustin requested changes Apr 23, 2024

View reviewed changes

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java Outdated Show resolved Hide resolved

ChangguHan added 2 commits April 24, 2024 14:34

[Issue-4917] Run blocking in ThriftCallService

d625b8f

[Issue-4917] add ThriftCallServiceBuilder

0963905

trustin reviewed Apr 30, 2024

View reviewed changes

[Issue-4917] fix to keep compatibility

aa97734

ChangguHan commented May 7, 2024

View reviewed changes

trustin reviewed May 7, 2024

View reviewed changes

jrhee17 reviewed May 8, 2024

View reviewed changes

[Issue-4917] fix to keep compatibility

649bf67

ChangguHan requested a review from trustin May 17, 2024 06:59

ChangguHan requested a review from jrhee17 May 17, 2024 06:59

ChangguHan added 3 commits May 17, 2024 19:06

[Issue-4917] fix to disallowed class(es) in the public API

b3dd89f

[Issue-4917] fix to checkstyle

78ff4d1

[Issue-4917] fix doc

abfc035

minwoox reviewed May 20, 2024

View reviewed changes

[Issue-4917] fix docs and add @UnstableApi

c072de7

	private boolean useBlockingTaskExecutor;
	private final boolean useBlockingTaskExecutor;

	* * ThriftCallService service = ThriftCallService
	* .builder()
	* .addService(defaultServiceImpl) // Adds an service
	* .addService("foo", fooServiceImpl) // Adds an service with a key
	* .addService("foobar", fooServiceImpl) // Adds multiple services to the same key
	* .addService("foobar", barServiceImpl)
	* .addService("foobarOnce", fooServiceImpl, barServiceImpl) // Adds multiple services at once
	* // Adds multiple services by list
	* .addService("foobarList", ImmutableList.of(fooServiceImpl, barServiceImpl))
	* // Adds multiple services by map
	* .addServices(ImmutableMap.of("fooMap", fooServiceImpl, "barMap", barServiceImpl))
	* // Adds multiple services by multimap
	* .addServices(ImmutableMultimap.of("foobarMultiMap", fooServiceImpl,
	* "foobarMultiMap", barServiceImpl))
	* .build();

	this.implementations.put(key, ImmutableList.of(implementation));
	implementations.put(key, ImmutableList.of(implementation));

	public static ThriftCallServiceBuilder builder() {
	@UnstableApi
	public static ThriftCallServiceBuilder builder() {

		* * <pre>{@code
		* * ThriftCallService service = ThriftCallService

	public final class ThriftCallServiceBuilder {
	@UnstableApi
	public final class ThriftCallServiceBuilder {

	* Adds an service for {@link ThriftServiceEntry}.
	* Adds a service for {@link ThriftServiceEntry}.

	requireNonNull(service, "service");
	requireNonNull(key, "key");
	requireNonNull(service, "service");

	Multimaps.asMap(servicesBuilder.build()).entrySet().stream().collect(
	servicesBuilder.build().asMap().entrySet().stream().collect(

[Issue-4917] Add blockingTaskExecutor in Thrift services #5619

Are you sure you want to change the base?

[Issue-4917] Add blockingTaskExecutor in Thrift services #5619

Conversation

ChangguHan commented Apr 18, 2024

CLAassistant commented Apr 18, 2024 • edited

github-actions bot commented Apr 18, 2024 • edited

🔍 Build Scan® (commit: c072de7)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChangguHan Apr 23, 2024 • edited

Choose a reason for hiding this comment

minwoox left a comment

Choose a reason for hiding this comment

minwoox left a comment

Choose a reason for hiding this comment

minwoox commented Apr 23, 2024

trustin left a comment

Choose a reason for hiding this comment

ChangguHan commented Apr 24, 2024

ChangguHan commented Apr 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trustin Apr 30, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trustin May 7, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jrhee17 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jrhee17 May 8, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minwoox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Apr 18, 2024 •

edited

github-actions bot commented Apr 18, 2024 •

edited

🔍 Build Scan® (commit: `c072de7`)

ChangguHan Apr 23, 2024 •

edited

trustin Apr 30, 2024 •

edited

trustin May 7, 2024 •

edited

jrhee17 May 8, 2024 •

edited