Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Multi modular lifting container #230

Draft
wants to merge 73 commits into
base: master
Choose a base branch
from
Draft

Conversation

Breush
Copy link
Contributor

@Breush Breush commented Aug 27, 2019

  • RNS Dixon solver (use Method::Dixon with multiModLifting = true) ;
  • Hadamard bound changed to be exact value (so that ratrecon can work nicely on small matrices).

@jgdumas jgdumas changed the title Multi modular lifting container [WIP] Multi modular lifting container Aug 28, 2019
@jgdumas
Copy link
Member

jgdumas commented Aug 28, 2019

WIP as still failing with clang++;
and with g++ more with O0 than O2

@jgdumas
Copy link
Member

jgdumas commented Aug 29, 2019

test-hadamard-bound.C:46:38: error: ‘FastHadamardBound’ was not declared in this scope
46 | double fastHb = FastHadamardBound(A);
| ~~~~~~~~~~~~~~~~~^~~
t

@Breush
Copy link
Contributor Author

Breush commented Aug 29, 2019

  • I added a static_assert to handle one bug when Modular<double> is not used.
  • The other bug is reproducible with clang with test-last-invariant-factor -n 1 -b 3, but isn't here when OMP_NUM_THREADS=1 is set.

@Breush
Copy link
Contributor Author

Breush commented Aug 30, 2019

To make ./test-last-invariant-factor -n 5 -b 10; fail, do:

@jgdumas jgdumas marked this pull request as draft December 3, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants