Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert limayaml functions to use pointer #2337

Merged
merged 3 commits into from May 20, 2024

Conversation

afbjorklund
Copy link
Contributor

Add a simple unit test for some coverage

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
@afbjorklund
Copy link
Contributor Author

afbjorklund commented May 12, 2024

Interesting failure, on Windows:

    validate_test.go:25: assertion failed: error is not nil: field `mounts[1].location` must be an absolute path, got "/tmp/lima"

Apparently using the "wrong" path.

i.e. it probably needs some TMPDIR

https://pkg.go.dev/os#TempDir

On Unix systems, it returns $TMPDIR if non-empty, else /tmp. On Windows, it uses GetTempPath, returning the first > non-empty value from %TMP%, %TEMP%, %USERPROFILE%, or the Windows directory. On Plan 9, it returns /tmp.

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
@AkihiroSuda
Copy link
Member

Could you explain the purpose of this?

@AkihiroSuda AkihiroSuda added this to the v0.23.0 (tentative) milestone May 18, 2024
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this, but still want to know the background

@AkihiroSuda AkihiroSuda merged commit 3b48462 into lima-vm:master May 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants