Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: retry commands that may segfault #156

Closed
wants to merge 1 commit into from
Closed

CI: retry commands that may segfault #156

wants to merge 1 commit into from

Conversation

siwatanejo
Copy link
Contributor

Retry commands, that may segfault, several times to make CI less flaky.

@webwarrior-ws @siwatanejo
CI: retry commands that may segfault
fd665d5 
Retry commands, that may segfault, several times to make CI
less flakey.
TheBlueMatt
TheBlueMatt reviewed Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by lightningdevkit/ldk-c-bindings#122

siwatanejo added a commit to packwallet/LdkSharp that referenced this pull request Mar 15, 2024
@siwatanejo
CI: remove retry logic
b865492 
Because it is claimed in upstream PR that this
has been fixed:
lightningdevkit#156
siwatanejo added a commit to packwallet/LdkSharp that referenced this pull request Mar 15, 2024
@siwatanejo
Revert 'CI: retry commands that may segfault'
22a7f9e 
This reverts commit 65e3756
because it is claimed in upstream PR that this
has been fixed:
lightningdevkit#156
siwatanejo added a commit to packwallet/LdkSharp that referenced this pull request Mar 15, 2024
@siwatanejo
Revert 'CI: retry commands that may segfault'
f111d36 
This reverts commit 65e3756
because it is claimed in upstream PR that this
has been fixed:
lightningdevkit#156
@TheBlueMatt
Copy link
Collaborator

Closing as fixed elsewhere.

@siwatanejo
Copy link
Contributor Author

@TheBlueMatt are you sure we don't need a retry? Latest master branch's CI status has several jobs failing, e.g. all the osx ones and the java_bindings one.

@TheBlueMatt
Copy link
Collaborator

The java one is indeed spurious, but just retrying isn't really a solution, github needs to fix their CI so that it has access to connect to github.com. The macOS ones have been broken for some time, they won't pass on a restart either.

@siwatanejo
Copy link
Contributor Author

siwatanejo commented Mar 21, 2024 •
edited

BTW, I see that jobs in master branch which don't correspond to a tag fail as well, because the invokation to git describe --tag HEAD will fail in that case. Shouldn't then those jobs be restricted to tags only, e.g. via adding if: startsWith(github.ref, 'refs/tags/') to the job(s), or job step(s)?

@TheBlueMatt
Copy link
Collaborator

Probably, but I haven't bothered.

@siwatanejo
Copy link
Contributor Author

Ok, I'll see if I contribute that improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siwatanejo @TheBlueMatt @webwarrior-ws