hsmd: add explicit hsmd_revoke_commitment_tx #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog-Added: Added hsm_capabilities and hsm_is_capable to channeld.
ChangeLog-Added: Added hsmd_revoke_commitment_tx to protect against local commitment persistance synchronzation errors with remote signers.
devrandom
reviewed
Jan 19, 2024
| @@ -1966,6 +1967,30 @@ static void send_revocation(struct peer *peer, | |||
|
|
|||
| peer->splice_state->await_commitment_succcess = false; | |||
|
|
|||
| /* Now that the master has persisted the new commitment advance the HSMD | |||
| * and fetch the revocation secret for the old one. */ | |||
| struct secret old_secret2; | |||
There was a problem hiding this comment.
consider removing these additional variables and just use old_secret and next_point everywhere below
There was a problem hiding this comment.
The problem is the originals are:
const struct secret *old_secret,
const struct pubkey *next_point,
|
looks good to me, just one nit |
Comment on lines
+2300
to
+2301
| if (HSM_MAX_VERSION < 5 || | ||
| !hsm_is_capable(peer->hsm_capabilities, WIRE_HSMD_REVOKE_COMMITMENT_TX)) |
There was a problem hiding this comment.
Mh this is just a comment for a future improvement. Would be nice to have a method to avoid checking the version here, but with the current enum system for the hsm_capabilities this seems hard
There was a problem hiding this comment.
not sure if we can hack around the hsmd_check_client_capabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://gitlab.com/lightning-signer/validating-lightning-signer/-/issues/207
Advances
HSM_MAX_VERSIONto 5 and addshsmd_revoke_commitment_tx.old_secretfrom the return value ofhsmd_validate_commitment_txhsmd_revoke_commitment_txafter master has syncd with validated local commitment tx to advance signer and receive theold_secretCode is forward and backward compatible with signers that have or don't have the feature.
Setting
HSM_MAX_VERSIONmanually to 4 will elicit the old behavior.