remote-hsmd on CLN v23.11 #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fications_received_via_websocket` function for other rpc requests too
…om notifications
Reported-by: Shahana Farooqui Changelog-Fixed: JSON-RPC: Plugin notification `msat` fields in `invoice_payment` and `invoice_created` hooks now a number, not a string with "msat" suffix. Changelog-Fixed: JSON-RPC: Plugin hook `payment` `msat` field is now a number, not a string with "msat" suffix.
This fixes a crash on startup of core-lightning where gevent could not be imported. This happens before sys is imported and throws us into the except clause which calls sys. By importing it explicitly in the except clause we are not dependend of the order of imports in the try bracket. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com> Changelog-Fixes: Plugin: clnrest crashed on startup when gevent was missing.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This caused a segmentation fault when calling `getcodexsecret` without id. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com> Changelog-Fixed: Hsmtool: Fix segmentation fault when calling `getcodexsecret` without id.
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
I guess this was to honor Aditya, but it was also a wrong example. Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
…ithub server at gitlab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS