Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds sass compile function #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adds sass compile function #45

wants to merge 3 commits into from

Conversation

andydlindsay
Copy link
Collaborator

  • Moves to SCSS compilation on server start/restart

@andydlindsay andydlindsay self-assigned this Jun 6, 2023
@FrancisBourgouin
Copy link
Contributor

Sounds great! A little over engineered (is that for the purpose of showing them more helper function actions?)

@andydlindsay
Copy link
Collaborator Author

I don't think there's any learning outcomes from this code. This PR is trying to simplify the process of how/when the SCSS gets compiled. The student will not need to edit or understand this code to make their project work.

Are there suggestions to simplify this code?

@FrancisBourgouin
Copy link
Contributor

FrancisBourgouin commented Jul 6, 2023 •
edited

I was thinking of just using plain sass --watch + nodemon with a package like concurently (https://github.com/open-cli-tools/concurrently)

  • add concurently to dependencies
  • npm run server => nodemon ./bin/www
  • npm run sass => sass --watch ./styles ./public/styles
  • npm run dev => concurrently "npm:server" "npm:sass"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancisBourgouin FrancisBourgouin Awaiting requested review from FrancisBourgouin

Assignees

@andydlindsay andydlindsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andydlindsay @FrancisBourgouin