Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wip): use bookworm-slim for docker base image #8648

Merged
merged 6 commits into from Jan 22, 2024

Conversation

owlas
Copy link
Collaborator

@owlas owlas commented Jan 18, 2024

current issues:

test-frontend test-backend test-cli

@owlas owlas requested a review from rephus January 18, 2024 14:13
@owlas owlas self-assigned this Jan 18, 2024
@owlas owlas requested a deployment to chore/dockerfile-bookworm-slim - jaffle_db PR #8648 January 18, 2024 14:13 — with Render Abandoned
@owlas owlas deployed to chore/dockerfile-bookworm-slim - headless-browser PR #8648 January 18, 2024 14:13 — with Render Active
Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for peaceful-bassi-cbf284 canceled.

Name Link
🔨 Latest commit c18c3a6
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-bassi-cbf284/deploys/65ae36cdcc25390008bf323e

@owlas owlas marked this pull request as draft January 18, 2024 14:51
@owlas owlas changed the title chore: use bookworm-slim for docker base image chore(wip): use bookworm-slim for docker base image Jan 18, 2024
@owlas owlas deployed to chore/dockerfile-bookworm-slim - headless-browser PR #8648 January 18, 2024 14:59 — with Render Active
@owlas owlas marked this pull request as ready for review January 18, 2024 16:11
@rephus
Copy link
Collaborator

rephus commented Jan 19, 2024

triggering tests

Copy link
Collaborator

@rephus rephus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update dockerfile-prs file

@rephus
Copy link
Collaborator

rephus commented Jan 19, 2024

I've manually created a new project snowflake + github

https://lightdash-pr-8648.onrender.com/projects/a646fe0e-220b-4a10-9d88-59d06fabdd30/tables/payments

@rephus
Copy link
Collaborator

rephus commented Jan 22, 2024

I got this error when trying to create a project

image

I installed git-all from apt

M  dockerfile-prs
@rephus
Copy link
Collaborator

rephus commented Jan 22, 2024

Fixed the git issue

We also need to install git on stage 3

image

M  dockerfile-prs
@owlas owlas temporarily deployed to chore/dockerfile-bookworm-slim - lightdash PR #8648 January 22, 2024 09:35 — with Render Destroyed
@owlas owlas temporarily deployed to chore/dockerfile-bookworm-slim - headless-browser PR #8648 January 22, 2024 09:35 — with Render Destroyed
&& apt-get clean

# Installing multiple versions of dbt
# dbt 1.4 is the default
RUN python3 -m venv /usr/local/dbt1.4
RUN /usr/local/dbt1.4/bin/pip install \
RUN python3 -m venv /usr/local/dbt1.4 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy how we do it on dockerfile

@owlas
Copy link
Collaborator Author

owlas commented Jan 22, 2024

Works well with bigquery + CLI workflow

@owlas owlas merged commit 45e4152 into main Jan 22, 2024
43 of 51 checks passed
@owlas owlas deleted the chore/dockerfile-bookworm-slim branch January 22, 2024 15:04
@lightdash-bot
Copy link
Collaborator

🎉 This PR is included in version 0.952.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants