Add --devel flag so helm can see rc.x versions #176
Conversation
ghost
assigned 
marcoderama
force-pushed
the
ariano.notiller
branch
from
3b36671
to
dd27120
Compare
| @@ -196,7 +196,7 @@ if [ "false" != "$ES_EXPORT_YAML" ]; then | |||
|
|
|||
| if [ -z "$ES_LOCAL_CHART" ]; then | |||
| TDIR=$(mktemp -d 2>/dev/null || mktemp -d -t 'install-es-tdir') | |||
| debug helm fetch -d $TDIR "$VERSION_ARG" "$chart_ref" | |||
| debug helm fetch -d $TDIR --devel "$VERSION_ARG" "$chart_ref" | |||
There was a problem hiding this comment.
according to man page --devel option is ignored when version is specified.
There was a problem hiding this comment.
Yeah. $VERSION_ARG will have a value if and only if the user specifies a value on the install-es.sh command line. If they do, --devel will be ignored. If they don't, it'll be empty and --devel will come into play.
|
To be honest this sounds good to me - helm doesn't install pre-release versions by default. It's not intuitive at all, but the feature itself is nice. |
|
And now that I think about it, we may want to change the install script to allow for installation of "stable" or "bleeding edge" versions. If "stable", then we don't consider |
Unbelievably (to me at least) helm ignores by default versions that look like
a.b.c.d-e. This means that the install script is currently ignoring our release candidates (e.g.1.0.0-rc.3).c.f. helm/helm#2407
Adding the
--develflag will pick them up.