[TS] LPS-188466 importing fragments with global scoped sitenavmenu fails #5514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
Could you please review this pull request?
https://liferay.atlassian.net/browse/LPS-188466
Thank you!
Reproduction Steps:
Go to Site Builder --> Pages and add a content (blank) page and add the created fragment to it, then click the fragment (it is so thin to be noticed). Change the “Pages Hierarchy” source by selecting the created navigation menu and then click on “Select this level”, then publish the page.
Go to Publishing --> Export and export the Site and download the LAR.
Go to Publishing --> Import and import the LAR into the same site.
Expected Result:* The import is successful with no issues.
Actual Result: The import fails with a UI error:
Solution:
If there's a reference from a regular site to the global (or basically any other) site, they will be exported as "missing reference". This was not handled in case of the SiteNavigationMenus, so I implemented doImportMissingReference method to do so.