Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm-scripts)!: update tools for react 18 #1178

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bryceosterhaus
Copy link
Member

This PR is a work in progress for our upgrade to react 18. I will make pre-releases from this branch to test in DXP

@bryceosterhaus
Copy link
Member Author

This should be good for release. Once I am able to get CI to pass in the liferay-portal PR, I will make a proper release of this and add to that PR.

@matuzalemsteles
Copy link
Member

@bryceosterhaus Oh, it's great to see that we are moving towards this, just a doubt if we had other problems, for example the entry of React 17.x brought changes to the global event system when preventing and for propagation 18.x introduced the new system competitor but still with incremental adoption, in the tests did you see anything different like the rendering behavior? side effects, for example in useEffect calls? Maybe this won't be a problem if you're not using StrictMode... Just curious if we can help with this on the Clay side, I remember having some Clay reports not working very well in React.js.

@bryceosterhaus
Copy link
Member Author

@matuzalemsteles still working on diagnosing CI errors in a bundle. So far I haven't seen any failures in the UI, but I need QA to do a full review of this pr, but CI has been a headache.

Since we aren't using StrictMode or any sort of server-side react code, I don't expect issues as that is where the bulk of updates have been for react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants