Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import an stb_vorbis fix from upstream PR/1563: #703

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

sezero
Copy link
Collaborator

@sezero sezero commented Nov 7, 2023

Patch by Seb de Graffenried (@Seb-degraff): nothings/stb#1563
Fixes distorted decompressed audio when UBSan was enabled.

Patch by Seb de Graffenried (@Seb-degraff): nothings/stb#1563
Fixes distorted decompressed audio when UBSan was enabled.
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #703 (5f221ea) into master (cc62388) will increase coverage by 0%.
Report is 22 commits behind head on master.
The diff coverage is 93%.

❗ Current head 5f221ea differs from pull request most recent head e08e77b. Consider uploading reports for the commit e08e77b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #703   +/-   ##
======================================
  Coverage      82%     82%           
======================================
  Files         171     171           
  Lines       31229   31271   +42     
======================================
+ Hits        25751   25793   +42     
  Misses       5478    5478           
Files Coverage Δ
src/common.h 100% <ø> (ø)
src/depackers/mmcmp.c 74% <100%> (ø)
src/loaders/amf_load.c 70% <100%> (+4%) ⬆️
src/loaders/iff.c 87% <100%> (ø)
src/loaders/stm_load.c 85% <100%> (+<1%) ⬆️
src/loaders/vorbis.c 72% <100%> (ø)
src/loaders/xm_load.c 85% <100%> (ø)
src/player.c 93% <100%> (-<1%) ⬇️
src/scan.c 97% <100%> (+<1%) ⬆️
src/loaders/imf_load.c 76% <86%> (-<1%) ⬇️
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499a617...e08e77b. Read the comment docs.

@AliceLR AliceLR merged commit ebc86c2 into libxmp:master Nov 7, 2023
16 checks passed
@sezero sezero deleted the stb0 branch November 7, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants