release/v0.3.x:cherry-pick:Add examples for userspace notification #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: libseccomp-rs#147 Signed-off-by: Mayank Mrinal <mayank.mrinal@sony.com>
ManaSugi
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/v0.3.x #263 +/- ##
===============================================
Coverage 97.05% 97.05%
===============================================
Files 13 13
Lines 1085 1087 +2
===============================================
+ Hits 1053 1055 +2
Misses 32 32 ☔ View full report in Codecov by Sentry. |
rusty-snake
reviewed
May 18, 2024
| /// | ||
| /// ``` | ||
| /// # use libseccomp::*; | ||
| /// let mut ctx = ScmpFilterContext::new(ScmpAction::Allow)?; |
There was a problem hiding this comment.
Suggested change
| /// let mut ctx = ScmpFilterContext::new(ScmpAction::Allow)?; | |
| /// let mut ctx = ScmpFilterContext::new_filter(ScmpAction::Allow)?; |
| /// # use std::process::exit; | ||
| /// // Get the current process ID | ||
| /// let parent_pid = std::process::id(); | ||
| /// let mut ctx = ScmpFilterContext::new(ScmpAction::Allow)?; |
There was a problem hiding this comment.
Suggested change
| /// let mut ctx = ScmpFilterContext::new(ScmpAction::Allow)?; | |
| /// let mut ctx = ScmpFilterContext::new_filter(ScmpAction::Allow)?; |
| /// # use std::process::exit; | ||
| /// // Get the current process ID | ||
| /// let parent_pid = std::process::id(); | ||
| /// let mut ctx = ScmpFilterContext::new(ScmpAction::Allow)?; |
There was a problem hiding this comment.
Suggested change
| /// let mut ctx = ScmpFilterContext::new(ScmpAction::Allow)?; | |
| /// let mut ctx = ScmpFilterContext::new_filter(ScmpAction::Allow)?; |
| /// # use libseccomp::*; | ||
| /// # use std::{fs::File, io::Read, process::Command, thread}; | ||
| /// let notify_fd = thread::spawn(|| -> Result<ScmpFd, error::SeccompError> { | ||
| /// let mut ctx = ScmpFilterContext::new(ScmpAction::Allow)?; |
There was a problem hiding this comment.
Suggested change
| /// let mut ctx = ScmpFilterContext::new(ScmpAction::Allow)?; | |
| /// let mut ctx = ScmpFilterContext::new_filter(ScmpAction::Allow)?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #147