Enable compilation on Fedora 41 on aarch64 #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to compile this libretro core on my Fedora aarch64 machine
I was getting this error:
mupen64plus-core/subprojects/minizip/zip.c:1249:28:
error: assignment to
‘const long unsigned int *’ from incompatible pointer type
‘const uint32_t *’ {aka ‘const unsigned int *’}
[-Wincompatible-pointer-types]
1249 | zi->ci.pcrc_32_tab = get_crc_table();
| ^
(redacted for clarity in this commit message)
Curiously, mupen64plus-core having the same minizip code didn't
suffer from this error. This is because there the problematic code
has been disabled by using exclusion defines NOCRYPT and NOUNCRYPT.
This commit tries to do the same for this repository.
Trying to compile this libretro core on my Fedora aarch64 machine I was getting: libretro/libretro.c:722:61: error: passing argument 2 of ‘co_create’ from incompatible pointer type [-Wincompatible-pointer-types] game_thread = co_create(65536 * sizeof(void*) * 16, EmuThreadFunction); (redacted for clarity in this commit message) The problem is that co_create() and pthread_create() are different APIs. While the former expects a void (*)(void), the latter expects a void * (*)(void *). This commit * redefines EmuThreadFunction so that it matches co_create() where it's used, and * creates a new wrapping function EmuThreadWrapper matching the function type expected by pthread_create(), where it's used.
On my system it was missing the inclusion of unistd.h. Mimic what's been done for MacOSX and conditionally add -DHAVE_UNISTD_H for this library.
|
Hi, sorry missed this PR. I will check it out by next week. I could swear i had some of the type missmatch stuff fixed before i cant remember where it went... |
|
I did this for my personal use and I thought I'd share. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of two compilation errors I was getting with the bundled zlib and minizip libraries, and one compilation error in libretro.c.