-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UWP MESA 4k fix #16522
UWP MESA 4k fix #16522
Conversation
Any reason why the OPENGL ifdefs are gone? If it does not hurt, could you reintroduce them again or was there a reason for its removal? |
Remove wrong resolution special handling for OPENGL
…this fixes max resolution being set to 1080p. As reading must be done inside an UI thread and is in fact an async operation which might delay frame generation, the reading itself is doen once and cached, give that changing resolution while the app is running is an unlikely corner-case use
Fix URL
They were removed because MESA was using another method to read those values which was not in synch with retroarch's one. HAVE_OPENGL was introduced to force that behavior when building against mesa (as there can be no OpenGL on UWP without it). Now that both MESA and Retroarch use the same way, there's no need to differentiate such behavior |
Alright then. |
Description
Fix for detecting resolutions higher than 1080p on XBOX UWP and Mesa. UWP API calls in MESA were misaligned
and reporting 1080p due to a known XBOX peculiarity. Besides, reading width and heigth must be done on UI thread so it might trigger unwanted waits, so caching values have been added to prevent multiple waits.
Related Issues
No official issues, this is XBOX specific
Related Pull Requests
No one, MESA was already integrated
Reviewers
@GABO1423