Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP MESA 4k fix #16522

Merged
merged 3 commits into from
May 17, 2024
Merged

UWP MESA 4k fix #16522

merged 3 commits into from
May 17, 2024

Conversation

aerisarn
Copy link
Contributor

Description

Fix for detecting resolutions higher than 1080p on XBOX UWP and Mesa. UWP API calls in MESA were misaligned
and reporting 1080p due to a known XBOX peculiarity. Besides, reading width and heigth must be done on UI thread so it might trigger unwanted waits, so caching values have been added to prevent multiple waits.

Related Issues

No official issues, this is XBOX specific

Related Pull Requests

No one, MESA was already integrated

Reviewers

@GABO1423

@LibretroAdmin
Copy link
Contributor

Any reason why the OPENGL ifdefs are gone? If it does not hurt, could you reintroduce them again or was there a reason for its removal?

aerisarn and others added 2 commits May 13, 2024 22:02
Remove wrong resolution special handling for OPENGL
…this fixes max resolution being set to 1080p. As reading must be done inside an UI thread and is in fact an async operation which might delay frame generation, the reading itself is doen once and cached, give that changing resolution while the app is running is an unlikely corner-case use
@aerisarn
Copy link
Contributor Author

Description

Fix for detecting resolutions higher than 1080p on XBOX UWP and Mesa. UWP API calls in MESA were misaligned and reporting 1080p due to a known XBOX peculiarity. Besides, reading width and heigth must be done on UI thread so it might trigger unwanted waits, so caching values have been added to prevent multiple waits.

Related Issues

No official issues, this is XBOX specific

Related Pull Requests

No one, MESA was already integrated

Reviewers

@GABO1423

Any reason why the OPENGL ifdefs are gone? If it does not hurt, could you reintroduce them again or was there a reason for its removal?

They were removed because MESA was using another method to read those values which was not in synch with retroarch's one. HAVE_OPENGL was introduced to force that behavior when building against mesa (as there can be no OpenGL on UWP without it). Now that both MESA and Retroarch use the same way, there's no need to differentiate such behavior

@aerisarn aerisarn closed this May 13, 2024
@aerisarn aerisarn reopened this May 13, 2024
@LibretroAdmin
Copy link
Contributor

Alright then.

@LibretroAdmin LibretroAdmin merged commit fe5c9a3 into libretro:master May 17, 2024
54 checks passed
Misunderstood-Wookiee added a commit to Misunderstood-Wookiee/RetroArch-UWP that referenced this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants