Add support for multimedia keys #16502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended RETROK_ values with 18 new items, commonly found on "multimedia" keyboards. Mapping added for SDL, X11, Wayland, dinput, winraw keymaps. Keyboard tester function of Remote Retropad extended to cover new keys. One fix in Android mapping for libretro#12986
|
No strong opinions, so from my point of view it is OK as it is. |
RobLoach
approved these changes
May 12, 2024
|
Sorry for the long wait @zoltanvb . Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a list of extra keys commonly found on "multimedia" keyboards: new RETROK_ entries and mappings for SDL, X11, Wayland, dinput, winraw drivers. Extend keyboard tester to cover also these keys.
Due to wide HW variety, there is no definite list, I used this collection which also agrees with my own memories of such a keyboard from several years ago.
Since the OS usually catches these keys before they reach RetroArch, the usefulness is mostly for Lakka or for Linux+KMS mode.
Using a programmable keyboard, I was able to hit most of the keys, see the last row of the extended keyboard tester:
The missing ones were not present in the mapping software. Assigning them to a hotkey was also tried.
Outline for adding a new key was used from the OEM_102 commit.
Leaving it in draft for a few days, as feedback would be welcome on:
Related Issues
Fixes #14298
Fixes #12986 (not related to new keys, but it is in the same mapping file)
Related Pull Requests
#16390