Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reverse DNS name for desktop file and icon #16449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ColinKinloch
Copy link
Contributor

Description

This MR renames the svg icon and desktop files to reverse DNS com.libretro.RetroArch.
This brings the desktop file in line with the FDO desktop file spec: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#file-naming

I have not tested this in any great detail. I'm not sure whether renaming these files will break anything.

This is the case for the Flatpak.

The fedora package uses this for the desktop file but not the icon: https://packages.fedoraproject.org/pkgs/retroarch/retroarch/fedora-40.html#files

This isn't the case for the arch linux package: https://archlinux.org/packages/extra/x86_64/retroarch/

Related Issues

#14521 (comment)

Reverse DNS being com.libretro.RetroArch
Copy link
Member

@RobLoach RobLoach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good. I don't see any other references to retroarch.desktop. I messed up the name when making the Flatpak build 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants